View Single Post
Old 02-02-2014, 01:13 PM   #24
eschwartz
Ex-Helpdesk Junkie
eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.eschwartz ought to be getting tired of karma fortunes by now.
 
eschwartz's Avatar
 
Posts: 19,421
Karma: 85400180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
Quote:
Originally Posted by arspr View Post
Entering brainstorming mode, outside team, non-expert, ignorant role:

Just in case you were so focused in solving the issue in an orthodox, "correct" way that you didn't think of this possible way. Although it has a probability of 99% of being just plain nonsense.

About killing the trailing obsolete branch of checkpoints: When you perform any automated action you have already set an add-checkpoint action which actually removes that branch. So AFAIK you only need to catch the manual "typing" event, because any automated one is already solved.

And thinking about that, it looks pretty similar to me to whatever mechanism you have implemented to detect the file-has-been-modified event. I mean when you open the book you somehow detect when the user modifies any text file, and then you put the pencil icon on its tab and you activate the save button.

I know it's not exactly the same case but, couldn't you "port" that detecting tool to the checkpoint cleaning?
I believe that's what he tried. The changelog for removal of this is:
Code:
         if is_modified:
             self.set_modified()
-            self.global_undo.truncate()
-            self.update_global_history_actions()
eschwartz is offline   Reply With Quote