MobileRead Forums - View Single Post

BetterRed · 10-13-2013, 08:25 PM

@tlindgren, @kiwidude and @DoctorOhh

Prior to 1.6, if you had books marked via the Temp Marker PI, and then you ran the Extract ISDN PI and you elected to update the books with the values, then a side-effect would be that the books that you had previously marked with Temp Marker would lose their marks.

So in that respect nothing has changed, this is the way the two plugins have always interacted, so if it's a 'bug' today, how come it wasn't a 'bug' yesterday.

The difference is that the 'marks' are now very visible in the Book List (spreadsheet) view, previously they were only visible in the recently added Cover Grid view via the presence of a gold star pasted onto the cover which was easily missed.

Marks put there by the ISDN PI are temporary - ie they don't persist across calibre sessions, just like the 'marks' put there by the Temp Marker PI and the new Mark Books feature.

But not all 'marks' are equal, at least one type of 'mark' does persist across calibre sessions. The Find Duplicates PI has an option to exclude apparent duplicates from reporting by future executions of Find Duplicates. It 'flags' the 'mark' with a not_book_duplicate attribute.

The Temp Marker PI would NOT include books 'marked' in this way in its Show marked books option. And the Find Duplicates PI would ONLY include books marked in this way in its Show all book duplicate exemptions option.

But this mutual exclusivity did not seem to 'work' in the Cover Grid view with respect to its Gold stars, which lead me to start the Show Marked as a Column thread. It was that thread that led to the Mark Books feature being implemented in the next release. And the 'problem' I saw with the Gold stars in the Cover Grid view are now manifested as Gold pins in the Book List View.

Feel free to blame me for the problems the Mark Books feature may have created, however I did foreshadow some of the potential consequences in the third paragraph of this post.

@kiwidude - I assume adding a not_book_duplicate tag to replace 'marks flagged' that way wont work unless Find Duplicates is updated to interrogate tags...

whilst Ψing

BR

10-13-2013, 08:25 PM	#274
BetterRed null operator (he/him) Posts: 21,763 Karma: 30237526 Join Date: Mar 2012 Location: Sydney Australia Device: none	@tlindgren, @kiwidude and @DoctorOhh Prior to 1.6, if you had books marked via the Temp Marker PI, and then you ran the Extract ISDN PI and you elected to update the books with the values, then a side-effect would be that the books that you had previously marked with Temp Marker would lose their marks. So in that respect nothing has changed, this is the way the two plugins have always interacted, so if it's a 'bug' today, how come it wasn't a 'bug' yesterday. The difference is that the 'marks' are now very visible in the Book List (spreadsheet) view, previously they were only visible in the recently added Cover Grid view via the presence of a gold star pasted onto the cover which was easily missed. Marks put there by the ISDN PI are temporary - ie they don't persist across calibre sessions, just like the 'marks' put there by the Temp Marker PI and the new Mark Books feature. But not all 'marks' are equal, at least one type of 'mark' does persist across calibre sessions. The Find Duplicates PI has an option to exclude apparent duplicates from reporting by future executions of Find Duplicates. It 'flags' the 'mark' with a not_book_duplicate attribute. The Temp Marker PI would NOT include books 'marked' in this way in its Show marked books option. And the Find Duplicates PI would ONLY include books marked in this way in its Show all book duplicate exemptions option. But this mutual exclusivity did not seem to 'work' in the Cover Grid view with respect to its Gold stars, which lead me to start the Show Marked as a Column thread. It was that thread that led to the Mark Books feature being implemented in the next release. And the 'problem' I saw with the Gold stars in the Cover Grid view are now manifested as Gold pins in the Book List View. Feel free to blame me for the problems the Mark Books feature may have created, however I did foreshadow some of the potential consequences in the third paragraph of this post. @kiwidude - I assume adding a not_book_duplicate tag to replace 'marks flagged' that way wont work unless Find Duplicates is updated to interrogate tags... whilst Ψing BR Last edited by BetterRed; 10-13-2013 at 08:32 PM. Reason: grammar