View Single Post
Old 09-06-2013, 02:30 AM   #21
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,475
Karma: 8025702
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by PatNY View Post
Here I ask you for an enhancement to CC, and it darn near breaks the layout for some! I hope it's not impacting too many of your customers.
Don't worry about it. It is a customer's job to ask for enhancements. It is my job not to break things.

My problem here: I didn't know that a system font size existed. I had never seen it, and all the Android text controls except WebView respect it automatically so had no reason to look for it. This isn't a *good* excuse. It just is.
Quote:
Originally Posted by PatNY View Post
After a little investigation tonight, I finally discovered what was inserting the font style & size tags into my comment sections. It happened whenever I copied and pasted text from a field inside of Calibre into the comments section. I often do that using the "Title" field when a book has a long subtitle. It has been happening for a long time, and though I had noticed this code before, I never had a clue how it got there.

I also discovered that if I pasted the text right next to existing normal text in the comments field (without spacing in between) then the font style and size tags would not be inserted. So at least there's a workaround.

Is this expected behavior for Calibre? Is it desirable? If not, is it something that can be even fixed? Or is it a Windows or Windows XP thing? I can’t imagine the intent was ever to insert a font family and font size when simply copying text from one of Calibre’s user fields into the comments box.
Sorry, but I don't know if it is expected or why it does it. Given that no one has noticed up to now it almost certainly isn't something that will be changed.
Quote:
Originally Posted by Purple Lady View Post
I do not have font size or style in my comments and the size is still too small in CC. Is there anything I can do or do I need to revert to the previous version?
You have three choices:
1) Revert
2) Live with it until the next CC release, probably in around 2 weeks
3) Change the system font size to Normal and up CC's font sizes. Yes, I know that this will break other apps so isn't very practical.
Quote:
Originally Posted by Purple Lady View Post
It doesn't matter what html you have in the comments, the font size still shows up smaller than everything else. I removed all html and made it plain text and the only difference is the bold and blank lines are gone - no change in font size (still small).
The problem is caused by changing the system font size. For example, if you change the font size to "Small" then the comments will be too large.
Quote:
Originally Posted by DoctorOhh View Post
Folks that use calibre often simply download metadata without regard to comment formatting. Thus creating great inconsistencies in formatting. If they are obviously too small folks edit that and remove the font size, but for normal div and P tags within calibre there is a tweak to adjust the book details page font size higher or lower as required.
Div and P tags don't cause any problem. Explicit font size tags in the comments may or may not be a problem. For example, I can easily imagine someone using larger font sizes for heading styles and wanting to see that larger font size.
Quote:
Originally Posted by DoctorOhh View Post
Since there are scores of different android devices out there, from an accessibility point of view, if an option in the settings to handle the html the new or old way is too complicated or time consuming to code then I would return to the previous method.

Your previous method created a uniform predictable viewing on the Book details page. Allowing folks with aging eyes easy access to the proper size font.

Respecting the html in comments may be more trouble than it is worth.
Two points here:
1) Respecting the system font size. I now know how to do that, and will add it.
2) Adding an option to go back to rich text. That is probably also worth doing. The question: which should be the default? My feeling is that HTML should not be the default, because people who see what they consider to be a problem are much more motivated to find a solution than are people who notice something odd but don't care that much. Also, this preserves/reverts to the old behavior.

Last edited by chaley; 09-06-2013 at 03:18 AM. Reason: Edit: changed default to not HTML
chaley is offline   Reply With Quote