View Single Post
Old 04-10-2013, 11:36 AM   #709
stepk
Groupie
stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.stepk ought to be getting tired of karma fortunes by now.
 
Posts: 165
Karma: 593460
Join Date: Oct 2012
Device: K5 B011 5.3.2.1
Quote:
Originally Posted by twobob View Post
KUAL_show_KUAL_buttons="1 2"
KUAL_show_KUAL_buttons="2 1"

^-- Working to hide kual buttons.
Nice. Order of incidence does not matter. Nor affects button order.
Hides Nicely (picture 1)

However, as shown in picture 1 any value whatsoever (other than commented out no-value default) causes the new logging button to not appear. Unsure if that is by design. "No value" shows all function options.
(picture 2)
I can't reproduce this issue. For me the new logging button appears when
1) KUAL_show_KUAL_buttons=""
2) #KUAL_show_KUAL_buttons="whatever"
note that 1 and 2 are equivalent - they both leave KUAL_show_KUAL_buttons unset, which looks up default value "1 2 3 99" (all currently defined buttons for the KUAL menu)
3) KUAL_show_KUAL_buttons="3" and no other KUAL button shows up

If I enter an invalid value, like KUAL_show_KUAL_buttons="-1" or " " the KUAL menu is not shown at all. You could qualify this as lack of defensive programming or a totally borky setting. I think it's the latter Besides, visibly reporting errors that involve KUAL.cfg is complicated, so I prefer to let some error manifest themselves in their obvious, non-destructive consequences - it's a kind of error reporting.

If I enter a mix of valid/invalid values, like "33 1 2" then the KUAL menu shows buttons 1 and 2. I think it works sensibly, don't you?

In summary: I can't reproduce this issue (with my current dev build).

Last edited by stepk; 04-10-2013 at 01:11 PM.
stepk is offline   Reply With Quote