MobileRead Forums - View Single Post - Disabled Actions still called by Keyboard Shortcut?

JimmXinu · 11-19-2012, 05:58 PM

Disabling self.menuless_qaction too does fix the problem. I've changed my code to:

Code:

    # disable when not in library. (main,carda,cardb)
    def location_selected(self, loc):
        enabled = loc == 'library'
        self.qaction.setEnabled(enabled)
        self.menuless_qaction.setEnabled(enabled)

Thanks for pointing it out.

Does that suggest that some of calibre's built in actions need that change, too?

I see the same issue--disabled button, but keyboard shortcut works with on last selected library book with ConvertAction, SendToDeviceAction and EditMetadataAction.

And a quick grep finds 12 places gui2/actions/*.py using 'self.qaction.setEnabled(enabled)'.

11-19-2012, 05:58 PM	#3
JimmXinu Plugin Developer Posts: 7,018 Karma: 4604635 Join Date: Dec 2011 Location: Midwest USA Device: Kobo Clara Colour running KOReader	Disabling self.menuless_qaction too does fix the problem. I've changed my code to: Code: # disable when not in library. (main,carda,cardb) def location_selected(self, loc): enabled = loc == 'library' self.qaction.setEnabled(enabled) self.menuless_qaction.setEnabled(enabled) Thanks for pointing it out. Does that suggest that some of calibre's built in actions need that change, too? I see the same issue--disabled button, but keyboard shortcut works with on last selected library book with ConvertAction, SendToDeviceAction and EditMetadataAction. And a quick grep finds 12 places gui2/actions/*.py using 'self.qaction.setEnabled(enabled)'.