View Single Post
Old 10-04-2012, 03:58 PM   #118
geekmaster
Carpe diem, c'est la vie.
geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.geekmaster ought to be getting tired of karma fortunes by now.
 
geekmaster's Avatar
 
Posts: 6,433
Karma: 10773670
Join Date: Nov 2011
Location: Multiverse 6627A
Device: K1 to PW3
Quote:
Originally Posted by knc1 View Post
[RANT]
Regular readers here are familar with GM's opinion on excessive whitespace in program code.

Here is mine:
Defines belong in the "include file" (*.h) ;
Code belongs in the "implementation file" (*.c) ;

That recommended practice is unknown to the folks at lab126.
[/RANT]

And to think, somebody actually paid those people to write this stuff.
Sadly, we cannot use eink include files if we want to support 5.0.x and 5.1.x kindles in one source module. The files for both firmwares have the same file name. The structures passed to the eink update ioctl() call have the same structure name, but DIFFERENT layouts. Instead of adding the new fields to the end of the structure to maintain compatibility, the inserted them in the middle, pushing critical fields to a different position in the different firmware versions.

I like to use includes, because it uses less space than copying the stuctures into your main source module.

I really do not like excessive vertical scrolling, whether it is through large source files with too much white space, or scrolling through directories filled gazillions of tiny source modules. I have five monitors in front of me, and I have nowhere near enough pixels for my needs. I hate important information NOT being right there in front of me, but having to search in buried windows, or unopened files, or offscreen in some scroll buffer. Using the mouse too much hurts my hand and fingers... Yuck! I need a WALL of pixels.
geekmaster is offline   Reply With Quote