Quote:
Originally Posted by olig
Hmmm... if I understand it right, your change does call get_metadata with extract_cover set to False. But this still returns the cover href (as I programmed odt get_metadata) and only does not return cover_data. A test also shows that it changes nothing.
|
Did read some more code... and it still looks wrong: as I understand it it removes the cover from the data which is given to OPFCreator. So in result I would suspect that it disappears from the OPF, not from the markup. This is exactly what I don't want.
The option that would help me is --dont-create-extra-titlepage. This is much better control over what the result should be than --remove-frist-image.
In retrospect I don't even know what the transform stage of the conversion pipeline expects to get from the input plugin. As I would understand it, it should be defined if a cover image should be in two places or only in one (the two places are the metadata and the actual markup).
As it is currently in two places, it is no wonder that the process creates another cover, as it seems to think: hey, there is a cover image in the metadata, it is certainly not in the markup, so I need to add it. From this it seems to me that the convert pipeline does not expect the cover to be in the markup if it is in the metadata.
On the other hand this robs the ability of control, because you can't put your cover on the second page (I don't really know if somebody wants to do this, it's hypothetical). So in my eyes you need to be able to forbid the creation of a titlepage at all.