MobileRead Forums - View Single Post

olig · 07-28-2012, 03:45 AM

Hmmm... if I understand it right, your change does call get_metadata with extract_cover set to False. But this still returns the cover href (as I programmed odt get_metadata) and only does not return cover_data. A test also shows that it changes nothing.

Here the first question is: if extract_cover is False, should get_metadata return neither cover nor cover_data? If yes, I need to change this.

But: I want it to have the cover href, so it is set as cover in the content.opf. So inhibiting the detection might be the wrong way. Except if metadata import/convert is separated from content import/convert (sorry, I'm not yet that deep into the code).

I still think selective removal of the detected cover image would be the better way to do it. I can also exactly identify this image in the ODT source, so I could also remove exactly this image.

07-28-2012, 03:45 AM	#22
olig Enthusiast Posts: 32 Karma: 12 Join Date: Jul 2012 Device: Kindle 4nt 4.1.3 jailbreak	Hmmm... if I understand it right, your change does call get_metadata with extract_cover set to False. But this still returns the cover href (as I programmed odt get_metadata) and only does not return cover_data. A test also shows that it changes nothing. Here the first question is: if extract_cover is False, should get_metadata return neither cover nor cover_data? If yes, I need to change this. But: I want it to have the cover href, so it is set as cover in the content.opf. So inhibiting the detection might be the wrong way. Except if metadata import/convert is separated from content import/convert (sorry, I'm not yet that deep into the code). I still think selective removal of the detected cover image would be the better way to do it. I can also exactly identify this image in the ODT source, so I could also remove exactly this image.