View Single Post
Old 07-19-2012, 03:03 AM   #619
kiwidude
Calibre Plugins Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,733
Karma: 2197770
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
Personally I think your approach is playing with fire, and taking away the prompt has missed the point of why the dialog is modal. Making it modal with a prompt ensures that (a) the user finishes whatever operations they currently have in progress before the update occurs, and (b) ensures the user cannot start any other activity which might update the database while the update occurs. Take away the prompt and you prevent neither of these. The user could be doing "anything" with the database at the time FFDL prepares to update - whether it is individual edits or bulk replace operations. Your database integrity is completely shot if there happens to be a conflict between whatever activity the user was doing and the background operation. And don't forget there is a data caching layer for the library view as well.

If putting in the prompts is Kovid's approach to deal with this issue (as he does in metadata downloads) then my plugins do the same. It eliminates any risk of data issues.
kiwidude is offline