View Single Post
Old 07-01-2012, 07:52 AM   #181
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,253
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
Quote:
Originally Posted by ldolse View Post
it's been a long time since I messed with this so I'd have to review the code in detail to answer this question fully. I don't think you'd get double margins from the plugin as it modifies both page and body margins - i.e. margins in body should be removed and everything would be in @page. It does sound like you're saying there may be an edge case if you run the plugin and then follow that by running a Calibre conversion. Calibre might insert the margins in the body tag whilst leaving @page alone, not sure of this, but since the whole point of the plugin is to avoid a Calibre conversion I'm not sure how critical it is. I sort of doubt this is an issue anyway as it could potentially happen with any number of retail ePubs as well and I haven't heard of Calibre doing that.]
I think the problem arises when the body tags in the html files are <body class="somename"> rather than simple <body>

and the non-zero body L/R margins are contained in the css file under .somename {margin...} rather than body{margin...}

Unfortunately, this would include all epubs which have already been calibre-converted plus some retail epubs.

Also, I know that a recent calibre change (much-appreciated, BTW) now puts any @page (and @font-face) in a 2nd page_styles.css file rather than in every single html file, but the current plugin does not remove @page from the htmls as part of this option. But maybe this was outside the scope.
jackie_w is offline   Reply With Quote