MobileRead Forums - View Single Post

cryzed · 07-01-2012, 07:33 AM

@JimmXinu, oh that might be, I'm not _that_ familiar with the whole architecture of the code, and good call on outputting all the non-valid entries. And yep, I only noticed the bug because I added parsing for the review count.

Also I feel that I should mention this: in FanFictionNetSiteAdapter.extractChapterUrlsAndMeta data at the very end you retrieve the chapter title, but this always includes the prefix, meaning: "X. XXXXX"; I did this to fix it: "title = title.split(None, 1)[1]". Related to this bug (I assume) I changed something in EpubWriter.writeStoryImpl around line 350 during the story cover generation:

PHP Code:


			
items.append(("file%04d"%i,
              "OEBPS/file%04d.xhtml"%i,
              "application/xhtml+xml",
              "%d. %s" % (index + 1, title)))

Namely the last line so it includes the now missing prefix. I assume that this is usually not included so it's your call to make, but don't you think that having index numbers in front of the chapter titles in the table of contents might make navigating easier? Example on how this all looks. Notice the missing number prefix for chapter titles and the added numbers in the table of contents.

07-01-2012, 07:33 AM	#488
cryzed Evangelist Posts: 408 Karma: 1050547 Join Date: Mar 2011 Device: Kindle Oasis 2	@JimmXinu, oh that might be, I'm not _that_ familiar with the whole architecture of the code, and good call on outputting all the non-valid entries. And yep, I only noticed the bug because I added parsing for the review count. Also I feel that I should mention this: in FanFictionNetSiteAdapter.extractChapterUrlsAndMeta data at the very end you retrieve the chapter title, but this always includes the prefix, meaning: "X. XXXXX"; I did this to fix it: "title = title.split(None, 1)[1]". Related to this bug (I assume) I changed something in EpubWriter.writeStoryImpl around line 350 during the story cover generation: PHP Code: `items.append(("file%04d"%i, "OEBPS/file%04d.xhtml"%i, "application/xhtml+xml", "%d. %s" % (index + 1, title)))` Namely the last line so it includes the now missing prefix. I assume that this is usually not included so it's your call to make, but don't you think that having index numbers in front of the chapter titles in the table of contents might make navigating easier? Example on how this all looks. Notice the missing number prefix for chapter titles and the added numbers in the table of contents. Last edited by cryzed; 07-01-2012 at 08:27 AM.