MobileRead Forums - View Single Post

cryzed · 06-30-2012, 10:57 PM

By the way, Jimm, I found the bug that prevents the fallback labels in base_writer.py (BaseStoryWriter.titleLabes) from being used when there is no title label specified in the configuration files.

Your call getConfigList(entry) in BaseStoryWriter.writeTitlePage always evaluates to true, because self.getConfig(key).split(',') in Configurable.getConfigList returns "['']" instead of "[]" even if empty due to your use of string.split, I added a simple if-statement checking if vlist equals [''], and in case it does set it to [] to circumvent that, you might prefer checking the length of the list and then the 0-index value.

Also, I'm not sure if this sounds useful to you (it certainly did to me though), a really easy way to implement being able to use HTML on the title page is this (line 20-21) in BaseStoryWriter.writeTitlePage; this way it is possible to relatively easy change the appearance of the title page, like so by modifying the "titlepage_entries" in the configuration file (I'm specifically talking about the line break between "Words" and "Summary").

06-30-2012, 10:57 PM	#483
cryzed Evangelist Posts: 408 Karma: 1050547 Join Date: Mar 2011 Device: Kindle Oasis 2	By the way, Jimm, I found the bug that prevents the fallback labels in base_writer.py (BaseStoryWriter.titleLabes) from being used when there is no title label specified in the configuration files. Your call getConfigList(entry) in BaseStoryWriter.writeTitlePage always evaluates to true, because self.getConfig(key).split(',') in Configurable.getConfigList returns "['']" instead of "[]" even if empty due to your use of string.split, I added a simple if-statement checking if vlist equals [''], and in case it does set it to [] to circumvent that, you might prefer checking the length of the list and then the 0-index value. Also, I'm not sure if this sounds useful to you (it certainly did to me though), a really easy way to implement being able to use HTML on the title page is this (line 20-21) in BaseStoryWriter.writeTitlePage; this way it is possible to relatively easy change the appearance of the title page, like so by modifying the "titlepage_entries" in the configuration file (I'm specifically talking about the line break between "Words" and "Summary"). Last edited by cryzed; 06-30-2012 at 11:04 PM.