MobileRead Forums - View Single Post

DiapDealer · 06-18-2012, 12:27 PM

Couple of things I'm noticing about 0.5.901:

On Windows... the supplied binary is not substituting the html entities for the three characters (soft-hyphen and m- and n-dash) as the code (and the devs) seems to suggest it should. I've tried on XP, Vista, Win7 32-bit, and Win7 64-bit. The original source of the ePub remains unchanged... entity stays entity and character stays character.

But if you take the 0.5.901 source package and build it on Linux (against Qt4.7.4)... the entity substitution does work as expected/advertised. And that behavior can be altered by tweaking the 'src/Sigil/ResourceObjects/HTMLResource.cpp' file.

So I tried building from source on Windows (Windows SDK nmake method)—against Qt4.8.2 and 4.7.4—and neither scenario will produce a binary that performs the above-mentioned character to entity substitution. Although they seem to build and perform fine otherwise.

**Also note that when building on Windows with the SDK nmake method, the ckeditor files are not being copied when executing 'nmake makeinstaller' and because of that, are not being included in the installer. There are no errors in the build process, ckeditor just isn't being included in the package. The cmake PRE_BUILD 'make_directory' command to create the ckeditor folder in the temp directory is working... but the cmake POST_BUILD 'copy_directory' command doesn't appear to be having the desired effect (src/Sigil/CMakeLists.txt). Doesn't seem to make a difference whether building with the SDK on XP or Win7

Am I just missing something in the Windows build process/environment? I'd like to be able to patch the 'src/Sigil/ResourceObjects/HTMLResource.cpp' file (as mentioned earlier by Ahmad Samir) to customize that character/entity substitution, but it just doesn't seem to have the same effect (or any, for that matter) that the same changes to that file in a Linux build do.

I'll wait and see what happens with the next beta, but I'm trying to get my build environments nailed down so I can produce customized builds for Windows and Linux that behave similarly.

06-18-2012, 12:27 PM	#100
DiapDealer Grand Sorcerer Posts: 28,716 Karma: 205159604 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Couple of things I'm noticing about 0.5.901: On Windows... the supplied binary is not substituting the html entities for the three characters (soft-hyphen and m- and n-dash) as the code (and the devs) seems to suggest it should. I've tried on XP, Vista, Win7 32-bit, and Win7 64-bit. The original source of the ePub remains unchanged... entity stays entity and character stays character. But if you take the 0.5.901 source package and build it on Linux (against Qt4.7.4)... the entity substitution does work as expected/advertised. And that behavior can be altered by tweaking the 'src/Sigil/ResourceObjects/HTMLResource.cpp' file. So I tried building from source on Windows (Windows SDK nmake method)—against Qt4.8.2 and 4.7.4—and neither scenario will produce a binary that performs the above-mentioned character to entity substitution. Although they seem to build and perform fine otherwise. **Also note that when building on Windows with the SDK nmake method, the ckeditor files are not being copied when executing 'nmake makeinstaller' and because of that, are not being included in the installer. There are no errors in the build process, ckeditor just isn't being included in the package. The cmake PRE_BUILD 'make_directory' command to create the ckeditor folder in the temp directory is working... but the cmake POST_BUILD 'copy_directory' command doesn't appear to be having the desired effect (src/Sigil/CMakeLists.txt). Doesn't seem to make a difference whether building with the SDK on XP or Win7 Am I just missing something in the Windows build process/environment? I'd like to be able to patch the 'src/Sigil/ResourceObjects/HTMLResource.cpp' file (as mentioned earlier by Ahmad Samir) to customize that character/entity substitution, but it just doesn't seem to have the same effect (or any, for that matter) that the same changes to that file in a Linux build do. I'll wait and see what happens with the next beta, but I'm trying to get my build environments nailed down so I can produce customized builds for Windows and Linux that behave similarly.