Quote:
Originally Posted by Koboyashi
Thank you  . Looks very nice. Well, I have some questions:
- What's the difference between Airplane, Toggle WiFi and WiFi on/off?
- What exactly happens while/after uninstalling the plugin?
|
Toggle WiFi and WiFi on/off are the same thing, but I have to admit I'm not 100% what it does since I didn't implement this. From looking at the code I'd guess clicking on WiFi on/off connect immediately without having to open the browser.
Uninstalling deletes the plugin shared library (libtweaks.so) and reboots using busybox reboot.
Quote:
Originally Posted by Koboyashi
And here comes my wishlist  :
- Please establish plugin versioning.
|
What exactly do you mean by this? The only versioning scheme that would make sense at the moment would be to include the git revision somewhere or to use the date as a version.
Quote:
Originally Posted by Koboyashi
- Add at least one blank line resp. a little space under every checkbox on the "Miscellaneous" page. At the moment, the design of this page is a little confusing.
|
Yes, the design is not perfect yet. It's the same with a few other elements, the header text isn't exactly where it should be etc.
Quote:
Originally Posted by Koboyashi
- Add language support. This could be realized by an INI file with entries like "Library=Bücherei" and so on, for each string. So the user may edit this file manually to suit the plugin for his own language.
|
We already have translations available using Qt Linguist, but they haven't been updated for the new GUI. I think at the moment you have to manually chose the language but that should improve in the future.
Quote:
Originally Posted by Koboyashi
- Improve the consistency between entries in the home menu and tweaks page.
|
After pressing the home button your settings should take effect, I'll remove the back arrow from the main settings page in the future. Or do you mean that the order is different/some things are named differently?
Quote:
Originally Posted by Koboyashi
- At first plugin run, create a complete INI file with all sections and entries (set to default). At the moment, one has to toggle each home menu option twice to create first a corresponding entry itself and then to set the desired entry value.
- Place a note that the device will reboot to uninstall the plugin.
- Remove the plugin INI file(s) while uninstalling.
|
There's a warning right above the uninstall button

. But you're right, having a confirmation dialog would be a good thing. But that's quite a bit of work since I'd have to write the missing headers for potentially a lot of stuff. Maybe in the future.
Also about the INI, I'm not sure what to do with it. Creating the ini file automatically creates versioning problems when the options change in the future and the ini gets out of sync. Also I'd prefer if it were unnecessary to edit any config files by hand.
Thanks for your input, I created issues on github for most of your points so hopefully they'll be implemented in the future.