View Single Post
Old 02-10-2012, 03:03 PM   #295
eureka
but forgot what it's like
eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.
 
Posts: 741
Karma: 2345678
Join Date: Dec 2011
Location: north (by northwest)
Device: Kindle Touch
@ixtab, diba, ok, guys, as I've informed you about possible danger of including translator-supplied URLs into a localization bundle, I believe that you are making a deliberate choice in current situation. So I'll not persist in obligatory blacklisting of URLs in Pillow/WAF resources.

But I have a compromise solution. Sometime later I'll introduce an option for controlling URL's blacklisting and then set blacklisting by default. Here is the complete plan:
  • introduce set of options for controlling blacklisting of URLs (say, --blacklist-all-urls and --no-blacklist-all-urls). Leave current behavior (no blacklisting) as default,
  • ask ixtab to use --no-blacklist-all-urls in localization bundles' producing,
  • after updating of bundles' producing pipeline, set --blacklist-all-urls as default behavior
So disabling of blacklisting will be an explicit choice. It will make me happier

Right now no URLs are blacklisted, so produced bundles will act as you like.

But there is a small defect with displaying of media player resource (not my fault). UTF-8 characters in that string with MessageFormat constructor are displayed on KT as garbage. It was noticed by JustAMan with cyrilllic characters. Can you confirm it? (It is a Pillow resource, trackCountMessageFormat property located at file strings/media_player_bar_strings.properties.) I have a bypass solution with encoding UTF-8 characters into a Unicode escape sequences on compiling (like: "превед" in this concrete property will be converted into a "\u043f\u0440\u0435\u0432\u0435\u0434" at the resulting JS file). It should work, but before implementing it I'd like to hear more reports about this weird behavior.

UPD Just for clarification. ixtab, if you are OK with current output of js_resources tool, then I have no objections against inclusion of Pillow/WAF part into localization bundles.

Last edited by eureka; 02-10-2012 at 03:17 PM. Reason: adding resume
eureka is offline   Reply With Quote