View Single Post
Old 06-03-2008, 12:09 PM   #67
=X=
Wizard
=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.=X= ought to be getting tired of karma fortunes by now.
 
=X='s Avatar
 
Posts: 3,671
Karma: 12205348
Join Date: Mar 2008
Device: Galaxy S, Nook w/CM7
@lisak
Wow you've completed re-wrote the code! I must say you did a bang up job.

@clement/lisak
The changes both lisak are very similar, however lisak did a much better job in cleaning up the code and commenting it. I recommend lisak's code be used for the next release. There is no need for any merging in either your code or my code, lisak's code is a complete re-write.

@lisak
Here are a few comments on you implementation

Keyboard: Is it possible to have two lay outs. Personally I like clements QWERTY lay out but I see value in the ABC... Is it possible to code two UI and have the user select their preference?

Logs: There are still logs getting pumped out, for releases it's best if we disable them.

LIB: I've recommend adding the line 'this.prepareScript()' to the 'loadDict' method. This will move the load time of the lib to the load time of the app, but this way the user will not experience a hit on their first word search. (having to wait for the app to load, then wait for the search is a pain)

// Here are some of my suggestions for keyboard mapping.
KeyMapping: In my release I changed a few buttons maps for quicker entries. I'd like to add these keys to your code. Change the <mark> button to call 'clearInput' Change the "Next/Prev" from find next word to moving the keyboard cursor left/right.

Last edited by =X=; 06-03-2008 at 12:11 PM. Reason: updated for clarification
=X= is offline   Reply With Quote