View Single Post
Old 08-13-2011, 11:46 AM   #474
BenChen
EPUB Metadata ******
BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.BenChen is not intimidated by interfenestral monkeys.
 
Posts: 525
Karma: 26874
Join Date: Dec 2010
Device: Kobo Glo HD
Quote:
Originally Posted by Mark Nord View Post
Hi Ben,

nice job.

But I couldn't resist to shorten your JS-code. Changes are pushed to apps-repository.

Regards
Mark

PS: We should also think about a more general approch with "key" instead of "button" and copy the key-functionality back to the Sim and PRS505/300

If I still could find the time...
Hi Mark,

Thanks for the condensing of the code! I sort of knew I was doing things "the long way", but I was happy just to get things working!

I have also just pushed changes to the repository getting the keyboard working for non-touch readers. And then I had to do a merge since I hadn't pulled your changes first! I think I got it all merged correctly.

I looked into "key" but my initial experimentations didn't work! So I went back to what I knew...

Now I will look at replacing my western keyboard with a cyrillic one. If that works, I will add the keyboard setting.

Sincerely,
Ben.
BenChen is offline   Reply With Quote