One for Kovid I guess...
I see you have a shiny new preference for editing keyboard shortcuts. My question concerns what does it mean from a plugin perspective?
You seem to have some kind of discovery going on, so I see some of the shortcuts for "Find Duplicates" and "Goodreads", "Open with" etc appearing in the new preferences screen.
I am imagining how this works is that because my plugins are registering keyboard shortcuts, you are then able through Qt to do some kind of "currently hooked in shortcuts" to display in the new dialog.
However I forsee a number of potential issues/conflicts. For instance since this functionality did not exist previously, all my plugins have had to have their own ability to both define and persist a shortcut. In some cases these are relatively simply defined being static - e.g. next/previous result for find duplicates. In other cases they are truly dynamic - e.g. Search the Internet or Open With, where a user can assign any number of shortcuts to "rows" of data.
So I can see a conflict happening if a user were to attempt to change a shortcut in your new dialog (as my plugin would try to register at startup its "known" shortcut that it has persisted). And your screen would not be able to allow configuring shortcuts for plugins for functions not yet assigned a shortcut, since it doesn't know about them.
Got any ideas as to what this means for plugins with keyboard shortcuts?
