View Single Post
Old 07-22-2011, 02:06 PM   #1
Halo
Connoisseur
Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.Halo did not drink the Kool Aid.
 
Halo's Avatar
 
Posts: 96
Karma: 72130
Join Date: Nov 2008
Location: San Francisco Bay Area, CA, USA
Device: Sony PRS-505, Kindle DX 1st Gen, Kindle Fire 1st Gen
Question Workflow for making and submitting changes

What is the recommended workflow for creating and submitting changes to calibre? Last night I was surprised to see that changes in my branch on Launchpad were merged into calibre. I had not requested the merge and was still working on it. That's ok, but it made me wonder if I was doing something wrong and should be using a different process.

Here's my workflow:
  1. bzr branch lp:calibre. I only need to do this once, right?
  2. bzr push lp:~mp/calibre/mybranch to create my new working branch on Launchpad.
  3. bzr pull to keep my checkout up-to-date.
  4. bzr commit occasionally to save my work.
  5. Request a merge via Launchpad when I am satisfied that my changes are safe to include.

Is this right? I've only done up to #4 but my changes were merged. Should I use a different process? Things were fine now but I am worried about if I make GUI changes that are experimental and things break. I want to make things easy on everyone.

I have no experience with version control systems and, despite reading the bzr manual, I am barely understanding the concepts of branching, merging, etc. Feel free to explain things to me like I'm a three-year-old.
Halo is offline   Reply With Quote