Quote:
Originally Posted by KevinH
Hi Steffen,
I called it version v0.28 to differentiate it. If it works okay for you, we can then integrate it into your git repository
|
I'm not so happy that you disabled skipping over sections which has been recognized as non-image sections.
As far as I know these non-image sections appear only at the end after all images, never between images, so it should not confuse the image name index if we just skip over them.
In that case we should also handle image sections where we can't determine the type as an error and print some message to stdout.
I think it might be even faster to just search all <img> tags in the source and then merge the source with the replaced <img> tags like we do the merge with in the "apply dictionary metadata and anchors" section.
Of course we have to skip over the original <img> tags in this merge, but as the match objects contain the position information where the found string was located, it should be very easy.
Since we have only the list of <img> tags in memory instead of all the splitted source file data, I expect that solution to be faster than your implementation.
Ciao,
Steffen