Quote:
Originally Posted by ldolse
I updated some of the dialog text based on silence being tacit approval to leave this tied with the xpgt margin removal, simple enough to change later if desired.
|
Sorry, I was working on some other plugins so I hadn't yet looked at or responded on this. Certainly without the ability to set the margins I would want the two as separate options, I don't want my Calibre 5pt l/r body margins obliterated but I do want xpgt ones removed.
However as I have other changes on my version of this plugin I need to integrate all of yours so it is easiest if yours are minimally isolated which your sticking it in with the xpgt stuff for now would do. Though if you are still working on this in terms of now considering supporting specifying margins (which will involve more intrusive changes unless you hardcode something for now) it is more problematic to keep merging them. So either I wait until you are done and merge it with mine, or I integrate now and then effectively play pass the parcel to you until you are 100% satisfactory this feature is done. I don't want to confuse people with forked versions on this thread or accidentally miss some change you make to it.
And yes I will also look at adding a matching check to Quality Check at some point, though as you point out it will likely not be as simple as just checking for the presence of a margin declaration. Since any book converted by Calibre will by default have 5pt l/r margins. Same deal applies - if you can do the work of writing the function I will add it to the plugin
