MobileRead Forums - View Single Post - ANN: FBReader v0.12.10 for DR1000 and DR800

Iñigo · 06-17-2011, 07:34 PM

[Only for DR800+ or Mackx's DR patch users]

FBReader toolbar at top wastes a lot of useful vertical space and many of the actions are already available from the menu... so why not remove it?
We could move main actions to DR bottom toolbar.

But this toolbar is managed by DR's popupmenu so I presumed it was a complex effort.
I was wrong, it was very easy in fact. You can see the code at [1] and a couple of screenshots attached.

The idea is to run FBReader from DR navigation always, not to run FBReader and open books from inside it.

Anyway this is not perfect. Here I list some issues:

1. I had to rename FBReader fullscreen-toolbar.xml file as toolbar.xml
Should we change FBReader package included toolbar or modify FBReader sources to check at runtime? We should find a solution for both advanced (dr800+ and mackx's patch) and normal users.
LATER: the best solution should be to ask which toolbar to use in the FBReader installation

2. FBReader contains a "library mode"
These options are not present on the menu so we would lose these features. Moreover, the only way to open a book will be selecting it on CTB.
LATER: not a problem for me, but don't know how other people use FBReader...

3. FBReader changes its own top toolbar contents in the ToC view, adding a new button/icon to back to reading.
As we won't show the top toolbar anymore we can't click on that icon. Only exit available is to select some section in the ToC or close the doc and open it again.
I think changing DR toolbar from FBReader could be hard and involve much time.

What do you think?

Iñigo
[1] https://bitbucket.org/inigoserna/dr8...t/085949957a13

06-17-2011, 07:34 PM	#86
Iñigo Guru Posts: 730 Karma: 72743 Join Date: Feb 2008 Location: Here or there Device: iRex iLiad, iRex DR800S. K4NT. Kobo Aura, Aura One, Libra 2.	Hide FBReader top toolbar and use DR bottom toolbar [Only for DR800+ or Mackx's DR patch users] FBReader toolbar at top wastes a lot of useful vertical space and many of the actions are already available from the menu... so why not remove it? We could move main actions to DR bottom toolbar. But this toolbar is managed by DR's popupmenu so I presumed it was a complex effort. I was wrong, it was very easy in fact. You can see the code at [1] and a couple of screenshots attached. The idea is to run FBReader from DR navigation always, not to run FBReader and open books from inside it. Anyway this is not perfect. Here I list some issues: 1. I had to rename FBReader fullscreen-toolbar.xml file as toolbar.xml Should we change FBReader package included toolbar or modify FBReader sources to check at runtime? We should find a solution for both advanced (dr800+ and mackx's patch) and normal users. LATER: the best solution should be to ask which toolbar to use in the FBReader installation 2. FBReader contains a "library mode" These options are not present on the menu so we would lose these features. Moreover, the only way to open a book will be selecting it on CTB. LATER: not a problem for me, but don't know how other people use FBReader... 3. FBReader changes its own top toolbar contents in the ToC view, adding a new button/icon to back to reading. As we won't show the top toolbar anymore we can't click on that icon. Only exit available is to select some section in the ToC or close the doc and open it again. I think changing DR toolbar from FBReader could be hard and involve much time. What do you think? Iñigo [1] https://bitbucket.org/inigoserna/dr8...t/085949957a13 Attached Thumbnails Last edited by Iñigo; 06-18-2011 at 06:31 AM.