View Single Post
Old 05-02-2011, 07:20 AM   #249
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,455
Karma: 8012886
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by kiwidude View Post
How often does it happen. Probably more than it should. I think the option of swapping names when adding authors is partly at fault, as if you have that selected it can give unintended results. It is once again that old chestnut of no setting for commas in a display name. So if I have a file with the name A B for author, and swap names checked, then I get the author B A rather than B, A. I think it could have it's logic tweaked to say if no comma when swapping then add one in and vice versa. However that might upset people who for some reason had the names stored without a comma the wrong way around and not want commas in the display name. How prevalent that is I do not know?
Given that one of the author_sort tweak options asked for supports B A, I think it might happen more than one would want.
Quote:
EDIT: I'm going to dispute my own suggestion here (I do talk to myself a lot). I think that differentiating between title vs author searches is wrong, they should both have this check. The question should be just whether identical author searches should have it or not. Which I think the correct answer is no. It means more code twiddling on my part but hopefully a more consistent result so you can get A B / B,A / B A and A,B all in the same group.
The problem you are considering stems from the fact that the author name order might not be consistent. Yes, this happens all the time. However, isn't checking for this a problem for Quality Check? If I first verify using Quality Check that my names are the way I want and fix the ones that are wrong, then doesn't the problem you are addressing here go away?

It might be that the importance of this issue is sufficient to embed a small quality check into the dups code, so that installing the quality check plugin isn't required. The problem I see is that the check has nothing to do with duplicates, so the UI and code isn't quite right. I suppose that you could construct a single dup group containing books with authors that don't conform to the desired format.
chaley is offline   Reply With Quote