Quote:
Originally Posted by dwanthny
The split jackets happened before Kovid put the jacket in the metadata. It occurred when you converted a book with a Jacket in it and your preferences had pagebreaks set to insert before all h1 tags? Which I think might have been default so split jackets as theducks describes were fairly common. You ended up with the title on one page and the author/series/comments on the next.
I PM'd you an example.
|
Thanks for the PM, just what I needed. Ick, what a mess in that book
And yeah it was the <h2> below the <h1> which caused the split as I expected. I'm sure I can come up with something to detect this.
One further question - this whole thing started because you asked for the ability to remove the "extra" jackets. Would it be safer just to have a single menu option of just remove "all" jackets? And then you regenerate to add an up to date one? Or would you want to have two menu options - one to remove all, and one that removes all except for one that has the calibre metadata tag on it?
I just wonder if you might get yourself in a mess not knowing what type of jacket is in what epub. For instance, if I expand the "check jacket" and "check multiple jackets" tests to cater for these extra scenarios, you aren't going to know whether your multiple jacket book has two old ones or an old one and a new one. Or indeed whether a book with a jacket has the new one or the old style one
Or should we instead have a check for "legacy" jackets?
Have a think about the permutations and tell me what you would like. I hate jackets myself, and remove *any* I find so I'm not representative of understanding the requirements of those who want to have one in one shape or form...