Quote:
Originally Posted by kiwidude
I would like to rip all my filth out and instead directly hook into the triggered signal of the clear search button action. You have any objections/thoughts on that? I should have pulled the pin on my current hacks and proposed this days ago, but I was playing whack-a-mole with the event triggering instead of a fresh perspective.
|
That seems fine to me.
You might also want to hook into gui.search_restriction.currentIndexChanged(int), so you will know if the user changes the restriction.
Quote:
|
So to make this plugin more complete/useful imho we *need* an ignore title based search.
|
I fully agree with this.
Quote:
|
I've only started last night thinking through all the implications and how it would fit. For instance when you are reviewing groups of authors, you are not going to want the "show all duplicates/highlight mode" option - instead it will be one group at a time and then the tag browser to filter within that group as you like or rename authors etc. So the Find duplicates dialog either needs a different dialog/menu option, or rearranging so that the options of how to view the results is either disabled or made a suboption of book based searches.
|
Well...
Doesn't this depend on my mental model at the time? If I am really looking for duplicate books and choose 'only author', then I might want to use groups and highlighting. Yes, this is a very fuzzy search, but that is what I asked for.
However, if my mental model is 'looking for author problems', then yes, I want to use group-at-a-time mode, and play with the tag browser etc. I also might want to use group-a-a-t mode if I am checking other metadata such as series or tagging issues.
What is wrong with adding an 'ignore title, fuzzy author' combination and leaving it up to me to choose how I want to see them? You might want to change the default to g-a-a-t, but I don't think you should prevent me from using highlighting.
Quote:
However I am convinced we do need ignore title searches, and if I have to rewrite the way I have done the code so far to support them then better to do that now and get it sorted while it is fresh in my mind than down the track imho. 
|
Oh yes, do get it right before you have users.
