View Single Post
Old 04-17-2011, 02:34 PM   #25
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,400
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Quote:
Originally Posted by kiwidude View Post
Funnily enough my Goodreads Covers plugin had a cache for lookup by title/author for books that did not have an isbn. But after writing all the code for that version of the metadata api I found I couldn't actually do title/author searches, only isbn ones .

Now that I can store Goodreads id I don't need a cache by anything else for my plugin - once you have hit a result the cache will key it by goodreads id and I can pull it back by that in future.
It's a little more subtle than that. The problem is suppose your plugin returns result1 and the amazon plugin returns result2. Further suppose that these results are not merged as described in my previous post. Now suppose the user picks result2. Then the identifiers that are passed to download_cover() will come from result2, not result1. So the download_cover in your plugin will not be able to key off the cached goodreads id.
kovidgoyal is offline   Reply With Quote