View Single Post
Old 04-15-2011, 07:33 AM   #79
kiwidude
Calibre Plugins Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,733
Karma: 2197770
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
Quote:
Originally Posted by ldolse View Post
I'll look into the plugin and pm/email you. I think all the building blocks are there already, just didn't want to jump into making unauthorized changes.
Sounds great. I have no problem at all with others like yourself making changes/additions, particularly if as you have you have asked first and then send them to me for review/release.

What I prefer not to see is someone making changes and then posting a forked version on the thread with no discussion first. I think it confuses users as to which version they should download etc. I'm working on these every day so it isn't as if you would have to wait long for me to release once we agree the changes, and I always give credit for contributions if that is a concern.

Of course if/when I stop contributing to the forums then someone else would have to take over the whole plugin maintenance thing. I'm doing my best to ram the features in off the todo list before that happens.

Quote:
Originally Posted by dwanthny View Post
I'd suggest looking for two book jackets. Looking for two xhtml files starting with jacket inside the epub.

I used the missing book jacket feature, then reconverted with book jackets. Checking a second time found 80% of the books as still missing the book jacket because they had an existing old jacket that the plugin checks first before it is able to find the new jacket.
Ahhh, I see the issue. Right now my check looks for any kind of jacket file, then looks for the calibre attribute on it and terminates the search at that point in that book. So if the first jacket file did not have the attribute, it says it has no jacket, even though the second jacket file does have the attribute.

I think that I should change the "Check has jacket" to look at all jacket files. And then add a new check of "Check multiple jackets" which does the additional request you have made.
Quote:
Personally I would love the option to remove all jacket*.xhtml files from the ePubs of selected books so I could start fresh with new jackets.
That's a good idea. I don't know how to implement it (yet) but I'll put it on the list. So you would use "Check EPUB has jacket" to display all the books with jackets, and then select them all (in your case), then use a "Remove EPUB jacket" on your selection. I know all the plumbing is there in Calibre to do it but it is a case of wiring it all in. It is one of those things that might be best done as a "job" that runs in the background I think like conversions do.
kiwidude is offline   Reply With Quote