View Single Post
Old 02-15-2011, 02:48 AM   #3
kiwidude
Calibre Plugins Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,735
Karma: 2197770
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
Quote:
Originally Posted by cybmole View Post
a metadata search / download will overwrite most things - author, title, cover... but it adds to summary text rather than overwrites.

so it's easy to get long summaries with duplicate text. would it not be more logical to overwrite this data

e.g. I download metadata, decide I don't really care for the cover, or the summary, so I delete ISBN, and download again, this time choosing a different match from the screen of matches. ... summary gets added to....
I've had this debate with Starson17 in the past on a ticket in the bug tracker. I think he may have made a few minor tweaks to it but basically we had problems reliably replicating the "exact doubling up". Though like you I had records which showed the same result of that. In some cases I found the duplicates were not quite exact - it is possible that I had added a missing space to end of a sentence, but then downloading again says "you are not exact" and doubles up...

I'm in your camp - I don't want summaries "appended" to under any circumstance. However the existing behaviour is to append if the comments differ in any way. The justification given that people may want additional reviews. I think when Kovid's new metadata download stuff comes in as a user the intent is to have more control over what gets overwritten etc.

In the meantime I just patched my local source code so it never overwrites if I have an existing value
Quote:
I'm not a fan of tags & social data so dunno if they overwrite or accumulate.
Tags accumulate. Everything else overwrites if it has a value from memory like series, rating etc. Some of this you can turn off if you don't want it at all in the configuration for the metadata download plugins. Personally I again "tweaked" the source code, such that it only puts in values if I don't have them and never appends.

Last edited by kiwidude; 02-15-2011 at 03:05 AM.
kiwidude is offline   Reply With Quote