View Single Post
Old 01-10-2011, 06:27 AM   #213
kiwidude
Calibre Plugins Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,733
Karma: 2197770
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
Quote:
Originally Posted by Bertrand View Post
Great ! It's time to test !

(Just one tiny cosmetic issue : is there a need to display checkboxes and drop down menus if a row is empty (no title/url/etc) ?)
Yeah I've agonised over that one too. The reason I haven't done that is is that there is no real "difference" between a row intended as a separator, and a row inserted intending to edit and turn into a menu item. If I remove the dropdowns etc on those blank rows then it would introduce an ordering dependency to "re-enable them", for instance by requiring the user to type into the menu text field first.

I think for consistency you would have to make all the columns non-editable on those blank rows until the user types a value in the menu text column. Then for you would also have to make it that if the user clears the menu text field all the other fields in the row get cleared too. Right now I have it discarding values in the separator rows behind the scenes when the user clicks the OK button, but it could be made more obvious by enforcing edit rules around the menu text column. Opinions anyone?

I'll send you a PM with the download link to test it as is if you don't mind and see what you think after trying it.
kiwidude is offline