Quote:
Originally Posted by erayd
Yep, although it's slid down my priority list somewhat - lots of talk, but only one person was prepared to have any meaningful interaction with the source, and only three people responded to the PHP poll. I've also had almost no feedback on the new code structure - if people like that approach, we can go with that, but if people would really prefer something else I'd rather know that up front so I can write something to fit rather than wasting a whole lot of time on something that will simply end up being replaced.
If people would rather I simply make unilateral decisions on the design of the project, I'm quite happy to just write whatever I prefer and upload that - but the impression I got was that you guys wanted to be involved throughout this process.
|
Hmm I wasn't aware of discussions not on this board, and sortof assumed proposal via code, like I did with the structure and functionality I added in the last r29mod. I poke at what is on github thusfar, and try to add r29 functionality, but it didn't seem like a completed skel. Admittedly I only skimmed it.
I did notice that the url matching seemed limited, with only 1 entry and no passing of match returns. The hash based stuff I coded allows for multiple patterns, detects ambiguity, and provides a means to call different functions based on which pattern got a hit. I'll try to make it more OO.
As far as decision making, I don't want to say the creator of fflag shouldn't be making them. But I also see myself proposing changes to things if it would result in more versatility or effeciency. If that would be more frustrating to you, I'll fork and annotate what's on git, instead of fork/alter/pull request.
Quote:
Are you referring to DOMXPath, or something else?
|
Yeah, that. All I need for vbulletin parsing is xpath matching. Not the extra troublesome baggage. Unfortunately, regex is not the best; matching the beginning is no problem, but finding the end where there are nested tags tends to be troublesome.
Perl's HTML::Treebuilder doesn't frak with encoding for instance.