View Single Post
Old 09-29-2010, 02:25 PM   #202
aleyx
Addict
aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.aleyx can self-interpret dreams as they happen.
 
Posts: 250
Karma: 20386
Join Date: Sep 2010
Location: France
Device: Bookeen Diva, Kobo Clara BW
Hello,

Quote:
Originally Posted by AtomicDryad View Post
Hiya, it seems like the commandline version hasn't worked for awhile, so I fixed it. I've also made other changes:
Some suggestions (I didn't read the code in detail, so maybe some don't apply):
  • A standard --version option; if multiple branches start getting used, it might be useful.
  • Output files in ~/tmp/flag/$FILENAME by default rather than the system-wide /tmp; maybe even ~/tmp/flag/$AUTHOR/$FILENAME for multiple inputs.
  • If you're adding multiple inputs, maybe also a standard @<filename> argument, where <filename> has one input per line (ex: "fflag -f epub @ids" would read the 'ids' file in the current directory, read its contents, and pass that as the inputs). this would allow a user to window-shop stories, copy/pasting IDs or URLs in a text file as they go, and when they're done they can convert everything in one short command.
  • A .conf file for overriding defaults. If we want to be thorough, we'll want a $PREFIX/etc/flag.conf for system-wide and a ~/.config/flag/flag.conf for user-specific.
  • Maybe putting a limit on the number of inputs. FFNet's TOS are pretty loose, but they do ask bots to only download a reasonable amount at once...

More generally, I think this project looks like a perfect candidate for OOP refactoring. I mean, pluggable codecs and sources? Available from CLI or web page? This is what classes are for. If erayd'll allow it, I'll volunteer; I'm really itching to do it...

N.
aleyx is offline   Reply With Quote