MobileRead Forums - View Single Post - iLiad Community iPDF

jharker · 10-23-2007, 02:22 PM

Historically, many people have proposed improvements to the pdf viewer. Many different versions of the viewer have been released, each with different features. To help solve this babel of versions, I propose that we create one centralized community version of the iPDF viewer, containing as many of the patches as can be comfortably combined together.

I'll volunteer to maintain this distribution, at least to start with. If you have a patch that you would like considered for inclusion, post it in this forum. Please put ONLY patch submissions in this thread.

Required Submission Components :

A clean patch for the iRex official iPDF source from subversion, svn 25. This patch should implement ONLY YOUR OWN modification when applied to a fresh download of the svn 25 source.
Clean patches for any other libraries, if necessary. For example, wpd's new "column viewer" mod requires a patch to the poppler library as well. Specify what source code the patch should be applied to.
Any other files that are required by the patch.
Full documentation of what new features and functionality the patch(es) add, including buttons that are added to the toolbar and what they do, and extra functionality added to hardware buttons.

Submission Guidelines :

Patches should apply equally to landscape and portrait mode, continuous and page modes.
Patches should not modify the default startup behavior of iPDF, except for loading previously-saved user changes.
Please be sure your patch is tested and as bug-free as possible.

Reference :

In Linux, you can get a copy of the current svn source using the command
Code:
```
svn co http://developer.irexnet.com/repo/applications/ipdf/trunk
```
In Linux, to make a proper patch file named my.patch, you can use this command (or something similar):
Code:
```
diff -r -u -N -b trunk trunk_new > my.patch
```

Those are the requirements to start with. In addition, I would like for mods to add new buttons to the toolbar, rather than using the hardware buttons; but I have no idea how this is done, or if this is even possible. If anyone would like to describe how to add toolbar buttons, that would be wonderful.

I will not necessarily include every modification in the community iPDF viewer. I may decline to include a patch for many reasons, including poorly written code, buggy code, lack of testing, irreconcilable conflicts with other patches, and excessive complexity of the UI. Having said that, I hope to see lots of great patches and I will include as many as I can!

Please put ONLY patch submissions in this thread. I will start a second thread for discussion of the community iPDF project and its component patches. Thanks!

10-23-2007, 02:22 PM	#1
jharker Developer Posts: 345 Karma: 3473 Join Date: Apr 2007 Location: Brooklyn, NY, USA Device: iRex iLiad v1, Blackberry Tour, Kindle DX, iPad.	Community iPDF - Patch submissions Historically, many people have proposed improvements to the pdf viewer. Many different versions of the viewer have been released, each with different features. To help solve this babel of versions, I propose that we create one centralized community version of the iPDF viewer, containing as many of the patches as can be comfortably combined together. I'll volunteer to maintain this distribution, at least to start with. If you have a patch that you would like considered for inclusion, post it in this forum. *Please put ONLY patch submissions in this thread.* Required Submission Components : A clean patch for the iRex official iPDF source from subversion, svn 25. This patch should implement ONLY YOUR OWN modification when applied to a fresh download of the svn 25 source. Clean patches for any other libraries, if necessary. For example, wpd's new "column viewer" mod requires a patch to the poppler library as well. Specify what source code the patch should be applied to. Any other files that are required by the patch. Full documentation of what new features and functionality the patch(es) add, including buttons that are added to the toolbar and what they do, and extra functionality added to hardware buttons. Submission Guidelines : Patches should apply equally to landscape and portrait mode, continuous and page modes. Patches should not modify the default startup behavior of iPDF, except for loading previously-saved user changes. Please be sure your patch is tested and as bug-free as possible. Reference : In Linux, you can get a copy of the current svn source using the command Code: svn co http://developer.irexnet.com/repo/applications/ipdf/trunk In Linux, to make a proper patch file named my.patch, you can use this command (or something similar): Code: diff -r -u -N -b trunk trunk_new > my.patch Those are the requirements to start with. In addition, I would like for mods to add new buttons to the toolbar, rather than using the hardware buttons; but I have no idea how this is done, or if this is even possible. If anyone would like to describe how to add toolbar buttons, that would be wonderful. I will not necessarily include every modification in the community iPDF viewer. I may decline to include a patch for many reasons, including poorly written code, buggy code, lack of testing, irreconcilable conflicts with other patches, and excessive complexity of the UI. Having said that, I hope to see lots of great patches and I will include as many as I can! Please put ONLY patch submissions in this thread. I will start a second thread for discussion of the community iPDF project and its component patches. Thanks!