Quote:
Originally Posted by Iņigo
Hi there,
@Iņigo: I noticed I found some different solutions for the same problems, I did not take your changes, but used my solution
Which problems and solutions?
|
(Ehhh, that was already some time ago) One of the things is configuring the _config folder, you did it in the source code and I did it with a define in a Makefile. I though there was another slight different solution for a simular 'problem'.
Quote:
Originally Posted by Iņigo
All in all I think we should unify the DR800 and DR1000 ports in an unique package to avoid confusing people (and also to have only one code to hack in).
|
That is why I included the changed files (4 make/configure files, 1 changed source file and two new source files). Now we need to find a volunteer
Quote:
Originally Posted by Iņigo
Currently, which are the differences between those? I know about:
1. taskbar code for DR1000
2. different toolbar.xml
... any more?
I suppose we could make 1. executed or not at runtime looking for some special feature of the device to differentiate between models.
And for 2. we could install one file for DR1000 and another for DR800.
|
For 1. I think it will not harm to run the code also for DR800, the standard iRex applications also do this (like uds and settings). The firmware (popupmenu) will react differently for the DR800 or the DR1000 version of the firmware. The ipc-code could be a starting point to determine what should happen if a 2nd-file is clicked when there is already a file opened in FBReader, open a new instance of FBReader, or close the current document and start the new document, reusing the existing FBReader instance.
For 2. Maybe it is possible to make a version that fits on the DR800 screen and still contains enough commands the DR1000?