MobileRead Forums - Importing multiple images

MobileRead Forums (https://www.mobileread.com/forums/index.php)

- Sigil (https://www.mobileread.com/forums/forumdisplay.php?f=203)

- - Importing multiple images (https://www.mobileread.com/forums/showthread.php?t=60568)

pedgarcia

10-27-2009 04:22 PM

Importing multiple images

1 Attachment(s)

Hi,

I've using Sigil to make epubs from some comics my kids like to read. In this particular comic book, each page contains several images (basically rows of images). To import these images to Sigil is painful because I need to do it one by one.

To help me in this task, I've modified Sigil to import multiples images at once, inserting a line break between images.

Just in case you think it can be useful for others and incorporated in the official source, the source code is attached here.

BTW, very nice job (code-wise speaking)!

Regards

Paulo

Valloric

10-27-2009 08:30 PM

The feature looks nice. I'll add it.

But in the future, do please create enhancement requests on the tracker. If you have a diff to submit, just attach it to the issue. Better yet, since Google Code allows for user Mercurial clones since a few weeks ago, you could have just created a personal clone, pushed your changes to it and then requested a pull.

Although this is small enough that it's not really a problem.

pedgarcia

10-27-2009 08:48 PM

Hi,

glad you liked it.

I don't have experience with Google code but I'll learn about you said and send updates in the proper way.

Regards

Paulo

Valloric

10-27-2009 08:53 PM

This functionality is now in the repo. My version doesn't add <br/> tags after images since those can screw up ADE if they are direct children of the <body> element.

The more important reason why <br> tags are not added is because Word 2007 inserts multiple images inline and not separated by a line break. Sigil tries to conform to standard practices when it can, Word being the gold standard for text editors.

pedgarcia

10-28-2009 10:08 AM

Hi,

yes, the <br> between images is convenient for me, but I think you're right to keep the standard practices.

Maybe in the future, if different behaviors for the same feature are necessary you could consider add an Configuration option page that allow the user changing the default.

Regards

Paulo

Valloric

10-28-2009 01:38 PM

Quote:

Originally Posted by pedgarcia (Post 640241)

Maybe in the future, if different behaviors for the same feature are necessary you could consider add an Configuration option page that allow the user changing the default.

Yes, an "Options" page is on my TODO list.

All times are GMT -4. The time now is 06:42 PM.