MobileRead Forums

MobileRead Forums (https://www.mobileread.com/forums/index.php)
-   Sigil (https://www.mobileread.com/forums/forumdisplay.php?f=203)
-   -   Sigil-1.7.0 Released (https://www.mobileread.com/forums/showthread.php?t=340797)

KevinH 08-02-2021 04:08 PM

Moving the setZoomFactor to the loadProgress slot allowed me to shrink the needed delay down to 30ms and still consistently see the syncing work.

So it helps but we still need the delay.

Pushed this to master since it is an improvement.

DiapDealer 08-02-2021 06:30 PM

Verified that the fix is working (at 30ms) on my overpowered Linux machine as well as my under-provisioned Windows 10 VM. Let's hope this is sufficient!

KevinH 08-02-2021 06:42 PM

Whew! That is good to know as we were rapidly running out of options.

Quote:

Originally Posted by DiapDealer (Post 4143646)
Verified that the fix is working (at 30ms) on my overpowered Linux machine as well as my under-provisioned Windows 10 VM. Let's hope this is sufficient!


DiapDealer 08-02-2021 07:12 PM

That's Qt5.15.2 on my Arch Linux machine, by the way. I confirmed the bug still existed before testing the fix. So it's clearly a long-standing problem.

Ashjuk 08-03-2021 04:21 AM

Quote:

Originally Posted by DiapDealer (Post 4143564)
It depends on the length of the file and where you are IN it as well. If the edits you're making are close enough to the top (or bottom) of a relatively small file, it's possible for the recent edit to still remain visible in the Preview Window even after the incorrect sync attempt. Try a good long xhtml file and scroll to the middle of it and see if that makes a difference.

I can see in the original images you posted that you're scrolled nearly to the bottom of the Preview Window. And that although the sync is still being botched after your edit, it's just not moving the needle enough to make a huge difference.

I have to admit I was using the test epub as supplied by Turtle. I will try the same process with a longer file to see what happens.

Quote:

Originally Posted by BeckyEbook (Post 4143566)
@Ashjuk: So how did you take your screenshots when we see Zoom 80% there? This can only be seen after clicking in the Preview window.
If you click on the Preview window, Code View synchronization will occur, and the problem we are discussing is Code View reverse synchronization -> Preview Window.

If you really have Code View 100% and Preview 80% then click on the red paragraph in the Code View and in the Preview window it will not be in the center, but a little above the center.

You are right, the edit point is a little above centre having inserted some text.

It seems I am getting confused because I was using the test epub which has relatively short files so the edit point does not move off screen.

Anyway you all appear to have fixed the bug so you should probably just ignore my ramblings. :)

KevinH 08-03-2021 10:57 AM

It is a timing thing so on some systems a delay of 0 (what Sigil 1.7 ships with) may actually work. On my system, that only works when zoom is 100%.

We could in fact use the current zoom value to decide how long or even if to delay. I will look into that.

Thanks for testing and reporting back.


Quote:

Originally Posted by Ashjuk (Post 4143748)
I have to admit I was using the test epub as supplied by Turtle. I will try the same process with a longer file to see what happens.


You are right, the edit point is a little above centre having inserted some text.

It seems I am getting confused because I was using the test epub which has relatively short files so the edit point does not move off screen.

Anyway you all appear to have fixed the bug so you should probably just ignore my ramblings. :)


Turtle91 08-04-2021 12:01 AM

Sorry it took a little bit to get back to you. I can confirm that switching the preview zoom to 100% fixed my issues.
yes, I know.... I'm always a little late to the party :(


Thanks Becky! And thanks to Kevin & Diap for looking into this!


All times are GMT -4. The time now is 10:13 PM.

Powered by: vBulletin
Copyright ©2000 - 3.8.5, Jelsoft Enterprises Ltd.
MobileRead.com is a privately owned, operated and funded community.