MobileRead Forums

MobileRead Forums (https://www.mobileread.com/forums/index.php)
-   KOReader (https://www.mobileread.com/forums/forumdisplay.php?f=276)
-   -   Page remaining bug (https://www.mobileread.com/forums/showthread.php?t=339843)

JSWolf 06-05-2021 12:41 PM

Page remaining bug
 
When I have the page number display to show the pages remaining, the last page shows -0/XXX. There is no such thing as a negative 0. Can this please be fixed so the last page is shown as -1/XXX? Thanks.

NiLuJe 06-05-2021 12:44 PM

Before another maths-inclined programmer jumps down your throat: yes, there is such a sign as a signed zero ;).

But, no, it doesn't make sense in this context ^^.

JSWolf 06-05-2021 12:47 PM

Quote:

Originally Posted by NiLuJe (Post 4127683)
Before another maths-inclined programmer jumps down your throat: yes, there is such a sign as a signed zero ;).

But, no, it doesn't make sense in this context ^^.

Is this an easy fix (I hope)?

NiLuJe 06-05-2021 12:52 PM

Can't think of a great way to handle this, though, because we can't just remove the hyphen, as that risks confusion with the page progress widget...

NiLuJe 06-05-2021 12:53 PM

Short of actually using another glyph entirely than a hyphen as a prefix? (But which one ^^).

JSWolf 06-05-2021 01:01 PM

I'm not asking to show 0/XXX. I'm asking for -1/XXX for the last page in the eBook.

NiLuJe 06-05-2021 01:15 PM

You already know that's going be a no, because it makes even less sense (but nice try ;p).

JSWolf 06-05-2021 05:53 PM

Quote:

Originally Posted by NiLuJe (Post 4127700)
You already know that's going be a no, because it makes even less sense (but nice try ;p).

It makes very good sense. 1 means I am on the last page. I am displaying the last page. 0 means nothing and I am not displaying nothing. I am displaying the last page. So that's 1.

The best thing to do would be to have the last pages be 1 or 0 with an option. I see no reason not to have such an option.

Ken Maltby 06-06-2021 12:22 PM

Just a thought; if you are on the last page of a chapter, there are no more pages in that chapter. There is not one more till the end. As an indicator of how many pages are left to reach the end of the the chapter, zero makes a lot of sense. As a means to establish how many pages to go until a good point to take a break, get some refreshments, take care of some other business, ect..., the current approach seems fine, to me.

Luck;
Ken

P.S.; Is this your second thread on this? (Might be thinking of a Github issue.)

NiLuJe 06-06-2021 02:30 PM

@Ken Maltby: Exactly (and, yes ^^).

In fact, with the other "in chapter progress" FR implemented in https://github.com/koreader/koreader/pull/7807, it becomes even clearer when you show the two widgets:

On a 10-page chapter, you go from 1 // 10 (=> 9) to 10 // 10 (=> 0). Remaining is *always* equal to total - pagenum (i.e., it's what's off-screen).

JSWolf 06-06-2021 02:42 PM

Quote:

Originally Posted by Ken Maltby (Post 4127988)
Just a thought; if you are on the last page of a chapter, there are no more pages in that chapter. There is not one more till the end. As an indicator of how many pages are left to reach the end of the the chapter, zero makes a lot of sense. As a means to establish how many pages to go until a good point to take a break, get some refreshments, take care of some other business, ect..., the current approach seems fine, to me.

Luck;
Ken

P.S.; Is this your second thread on this? (Might be thinking of a Github issue.)

But, when you see that you have 10 pages left in the chapter, that's incorrect because you really have 11 pages to read. So you think you have to read 10 pages to finish the chapter but it's really 11. That's misleading.

Now, what is wrong with an option to allow page numbers to be done either way? Nothing at all. So I don't see why there is such reluctance to add in such an option. So if you want it as page 1 or page 0, you get what you want.

Jellby 06-06-2021 04:57 PM

Quote:

Originally Posted by JSWolf (Post 4128033)
But, when you see that you have 10 pages left in the chapter, that's incorrect because you really have 11 pages to read. So you think you have to read 10 pages to finish the chapter but it's really 11. That's misleading.

I see the footer when I finish reading the page, by then I have already read the page on display and I have indeed 10 left to read. When I page forward, I don't care what the footer says, my eyes go to the top of the page and only after reading the page I see the footer, and it says 9 pages left.

JSWolf 06-06-2021 06:08 PM

Quote:

Originally Posted by Jellby (Post 4128065)
I see the footer when I finish reading the page, by then I have already read the page on display and I have indeed 10 left to read. When I page forward, I don't care what the footer says, my eyes go to the top of the page and only after reading the page I see the footer, and it says 9 pages left.

I do look at the number of pages left in a chapter when I get to a new chapter before I read any of it. The problem is that the number is incorrect. If the chapter is 10 pages, it will show as 9 instead of 10. When I see the number, I have 10 pages to read, not 9.

Jellby 06-07-2021 03:53 AM

On the other hand, the last page of the chapter may be just 4-5 lines long, and the first page probably has a title that takes that much space. So over all, the count might be even more correct than if you add 1 ;)

Zetmolm 06-07-2021 04:55 AM

To add to the confusion: Some books don't have a page break for a new chapter. A new chapter may begin in the middle of a page. Koreader then tells me I have 0 pages left when I'm on the last full page of the chapter, i.e. I have another half page on average to go. It would be much better in this situation if the 0 is shown on the page of the chapter break.


All times are GMT -4. The time now is 09:01 PM.

Powered by: vBulletin
Copyright ©2000 - 3.8.5, Jelsoft Enterprises Ltd.
MobileRead.com is a privately owned, operated and funded community.