MobileRead Forums

MobileRead Forums (https://www.mobileread.com/forums/index.php)
-   Sigil (https://www.mobileread.com/forums/forumdisplay.php?f=203)
-   -   Sigil-1.5.0 Beta Released (https://www.mobileread.com/forums/showthread.php?t=338142)

odamizu 03-23-2021 02:02 PM

Thank you so much for all this effort. Much appreciated!

DiapDealer 03-23-2021 02:22 PM

Maybe check with some international Windows users who make extensive use of the AltGr key to make sure it doesn't throw a wrench in the works.

To be honest... I had no idea there were any kind of "industry standard" word-highlighting shortcuts before this thread. I'm a dyed-in-the-wool manual highlighter, myself. So all highlighting shortcuts will probably interfere with my double-clicking habits. ;)

Ashjuk 03-23-2021 02:27 PM

Quote:

Originally Posted by DiapDealer (Post 4105557)
To be honest... I had no idea there were any kind of "industry standard" word-highlighting shortcuts before this thread. I'm a dyed-in-the-wool manual highlighter, myself. So all highlighting shortcuts will probably interfere with my double-clicking habits. ;)

Me neither - I'm strictly a click-and-drag man myself. :)

KevinH 03-23-2021 02:33 PM

BeckyEbook tested this for us and using the left alt (not altgr) on international keyboards seems to work just fine.


Quote:

Originally Posted by DiapDealer (Post 4105557)
Maybe check with some international Windows users who make extensive use of the AltGr key to make sure it doesn't throw a wrench in the works.

To be honest... I had no idea there were any kind of "industry standard" word-highlighting shortcuts before this thread. I'm a dyed-in-the-wool manual highlighter, myself. So all highlighting shortcuts will probably interfere with my double-clicking habits. ;)


DiapDealer 03-23-2021 02:35 PM

Quote:

Originally Posted by KevinH (Post 4105560)
BeckyEbook tested this for us and using the left alt (not altgr) on international keyboards seems to work just fine.

I thought that would be the case, but wanted to be sure.

KevinH 03-23-2021 02:44 PM

Interestingly the Linux CI failed with my push of this to master. The failure seemed related to python3 and not Qt 5.9 specific. It passed on Windows and macOS. Any ideas?

DiapDealer 03-23-2021 03:19 PM

Quote:

Originally Posted by KevinH (Post 4105564)
Interestingly the Linux CI failed with my push of this to master. The failure seemed related to python3 and not Qt 5.9 specific. It passed on Windows and macOS. Any ideas?

I'll take a look. It's probably not anything code related. More likely a CI environment issue of some kind.

Doitsu 03-23-2021 03:22 PM

Quote:

Originally Posted by KevinH (Post 4105564)
Interestingly the Linux CI failed with my push of this to master. The failure seemed related to python3 and not Qt 5.9 specific. It passed on Windows and macOS. Any ideas?

I just built Sigil 1.5.0 without problems on my Arch Linux machine:
Qt: 5.15.2
Python: 3.9.2

DiapDealer 03-23-2021 03:46 PM

I think we're good now. Something must have changed on the Ubuntu 18.04 runner image. I had to specifically make sure the python3 (that already comes preinstalled with the image!) was set up, apparently.

odamizu 03-23-2021 05:45 PM

This is great! Thank you!

Maybe it's just a Mac thing, but double-clicking on a word to select it, and triple-clicking on a word to select the entire paragraph, is something I've been doing for decades and works in pretty much all Mac programs. Also, double-clicking a word then dragging will select all whole words in the drag, so you don't have to fiddle with the mouse to be precise.

un_pogaz 03-23-2021 07:28 PM

Quote:

Originally Posted by odamizu (Post 4105596)
Maybe it's just a Mac thing, but double-clicking on a word to select it, and triple-clicking on a word to select the entire paragraph, is something I've been doing for decades and works in pretty much all Mac programs. Also, double-clicking a word then dragging will select all whole words in the drag, so you don't have to fiddle with the mouse to be precise.

Same behavior on Windows on my side for the Double-click.

To answer at KevinH question, I prefer the A for the Shift+Double-click (select the content), mainly because it is easier to remove empty tags by others shortcuts and features.

But abandoning the other behavior would be a shame, because selecting the whole tag is really convenient.
I suggest that you try to add Shift+Ctrl+Double-click to select the entire tag.
Code-side, you would just have to prioritize (or somehow else) the Shift+Ctrl+Double-click, to maintain the "go to CSS rule" behavior of the Ctrl+Click (which is also very cool).

Spoiler:
I don't know how C++ works, so forgive me if this idea is stupid, or impossible to implement for technical reasons:
Code:

if Shift and !Ctrl:
  if Double-click:
    select_content_tag();

else if Shift and Ctrl:
  if Double-click:
    select_tag();

else if Ctrl and !Shift:
  if Click:
    go_to_css();


Tex2002ans 03-23-2021 08:02 PM

Quote:

Originally Posted by odamizu (Post 4105596)
Maybe it's just a Mac thing, but double-clicking on a word to select it, and triple-clicking on a word to select the entire paragraph, is something I've been doing for decades and works in pretty much all Mac programs. Also, double-clicking a word then dragging will select all whole words in the drag, so you don't have to fiddle with the mouse to be precise.

Double-click to highlight per word is functionality that works across all(?) OSes.

Same thing can be done in Android (and iOS). If you press-and-hold+drag, you're able to highlight per word. Much better than dragging those "handles" on either side.

KevinH 03-23-2021 08:20 PM

Normal double-click behaviour has now been restored in master for Sigil-1.5.1

- Double-Click selects word under cursor anyplace (restoring previous behaviour)

- Shift Doubleclick in a tag selects that tags contents

-Alt Doubleclick in a tag selects that tag and its contents.

Tex2002ans 03-23-2021 08:29 PM

Quote:

Originally Posted by KevinH (Post 4105626)
Normal double-click behaviour has now been restored in master for Sigil-1.5.1

- Double-Click selects word under cursor anyplace (restoring previous behaviour)

- Shift Doubleclick in a tag selects that tags contents

-Alt Doubleclick in a tag selects that tag and its contents.

:thumbsup:

odamizu 03-23-2021 10:39 PM

Quote:

Originally Posted by Tex2002ans (Post 4105625)
Double-click to highlight per word is functionality that works across all(?) OSes.

In that case, even more reason to restore this behavior :)

I just wondered since this seemed unfamiliar to some.

Quote:

Originally Posted by KevinH (Post 4105626)
Normal double-click behaviour has now been restored in master for Sigil-1.5.1

- Double-Click selects word under cursor anyplace (restoring previous behaviour)

- Shift Doubleclick in a tag selects that tags contents

-Alt Doubleclick in a tag selects that tag and its contents.

:thanks: :thanks:


All times are GMT -4. The time now is 10:49 PM.

Powered by: vBulletin
Copyright ©2000 - 3.8.5, Jelsoft Enterprises Ltd.
MobileRead.com is a privately owned, operated and funded community.