MobileRead Forums

MobileRead Forums (https://www.mobileread.com/forums/index.php)
-   Sigil (https://www.mobileread.com/forums/forumdisplay.php?f=203)
-   -   Sigil-0.9.0 Release (https://www.mobileread.com/forums/showthread.php?t=267232)

Turtle91 11-07-2015 06:13 PM

1 Attachment(s)
Fairly short process:

- Generate Table of Contents
- Save ePub
- Generate HTML Table of Contents
- Edit HTML TOC
- Save ePub
- Check "sgc-toc.css" that was generated from a template when creating HTML TOC.
- SOMETIMES the css is blank, other times it's not.

It will never blank if I edit the css file and add a space somewhere as soon as it's created.

Here is the css template file if you'd like to look, but I doubt that is the issue since it does work sometimes.

KevinH 11-07-2015 06:38 PM

Hi,
If it comes from the sgc-toc.css stored as a template in Prefs location, and if I can track down where that file is first loaded in BookBrowser, and your steps will recreate it at least randomly, I should be able to make it do an initial load as well.

Thanks!

KevinH

KevinH 11-07-2015 07:31 PM

Hi,

I still can't reproduce it but from examining the code, the same issue we fixed for Adding Existing CSS files, seems to exist when the template css file from Preferences is used in its place.

So our next release will include a fix for this issue (required changes to MainWindow.cpp similar to what we added to BookBrowser).

This is quite a long-standing bug in Sigil since Sigil 0.7 or even Sigil 0.6 I think. Nice to finally track this one down and get it fixed.

Thanks,

KevinH

BetterRed 11-07-2015 08:26 PM

On Windows can I install 0.9.0 64bit and 0.8.6 32bit on the same machine and have them use the same settings data in %userprofile%/appdata/local/sigil-ebook. I do not want to run both concurrently.

BR

DiapDealer 11-07-2015 08:47 PM

Quote:

Originally Posted by BetterRed (Post 3201991)
On Windows can I install 0.9.0 64bit and 0.8.6 32bit on the same machine and have them use the same settings data in %userprofile%/appdata/local/sigil-ebook. I do not want to run both concurrently.

BR

You can, but it's not really recommended. All versions of Sigil (official versions) installed on the same machine (under the same user) will share the same user-settings. There may be no problems at this time, but there's no guarantee that settings in the 0.9.X (and newer) series will remain backward-compatible with older versions of sigil.

Steadyhands 11-07-2015 09:02 PM

Has there been a change in the way <br> is treated within headers?

I've recently upgraded to 0.9 and seen this change upon opening an existing file.

<h2>1<br /> Bla Bla</h2> v0.8.7

<h2>1<br />

Bla Bla</h2>v0.9.0

BetterRed 11-07-2015 09:07 PM

Quote:

Originally Posted by DiapDealer (Post 3202004)
You can, but it's not really recommended. All versions of Sigil (official versions) installed on the same machine (under the same user) will share the same user-settings. There may be no problems at this time, but there's no guarantee that settings in the 0.9.X (and newer) series will remain backward-compatible with older versions of sigil.

:thumbsup:

BR

Turtle91 11-07-2015 09:45 PM

Quote:

Originally Posted by KevinH (Post 3201963)
Hi,

I still can't reproduce it but from examining the code, the same issue we fixed for Adding Existing CSS files, seems to exist when the template css file from Preferences is used in its place.

So our next release will include a fix for this issue (required changes to MainWindow.cpp similar to what we added to BookBrowser).

This is quite a long-standing bug in Sigil since Sigil 0.7 or even Sigil 0.6 I think. Nice to finally track this one down and get it fixed.

Thanks,

KevinH

Glad to help! Thanks!!

Turtle91 11-07-2015 09:45 PM

Quote:

Originally Posted by Steadyhands (Post 3202012)
Has there been a change in the way <br> is treated within headers?

I've recently upgraded to 0.9 and seen this change upon opening an existing file.

<h2>1<br /> Bla Bla</h2> v0.8.7

<h2>1<br />

Bla Bla</h2>v0.9.0

It's been doing that as far back as I can remember.

KevinH 11-07-2015 10:50 PM

Hi,
If you are talking about prettyprint gumbo, then yes Sigil will do that. If you don't want Sigil to prettyprint then change your preferences to use just gumbo.

KevinH

Quote:

Originally Posted by Steadyhands (Post 3202012)
Has there been a change in the way <br> is treated within headers?

I've recently upgraded to 0.9 and seen this change upon opening an existing file.

<h2>1<br /> Bla Bla</h2> v0.8.7

<h2>1<br />

Bla Bla</h2>v0.9.0


JeffJ 11-08-2015 03:04 PM

I have v0.9.0 x64 installed on Windows 7 and have noticed a problem with the table of contents. When I 'add existing files' with this header
<h2 class="hdr-2" id="Ch01">Chapter 1:<br />Chapter Title</h2>
it gets added as
<h2 class="hdr-2" id="Ch01">Chapter 1:<br/>

Chapter Title</h2>
This produces a truncated table of contents entry
Chapter 1:
but the correct HTML table of contents entry
Chapter 1: Chapter Title

If I remove the extraneous blank line like so it's like this
<h2 class="hdr-2" id="Ch01">Chapter 1:<br/>
Chapter Title</h2>
both the table of contents entry and the HTML table of contents entry are correct.
Chapter 1: Chapter Title
Chapter 1: Chapter Title

Although it's fairly easy to go and remove the extra blank line this seems almost like a bug to me, but what do I know.

KevinH 11-08-2015 03:27 PM

Are you setting your Preferences to clean on Open or Save and if so are you telling it to use PrettyPrint or not? If so, do not use PrettyPrint Gumbo. Use normal Gumbo which makes fewer changes.

Steadyhands 11-09-2015 04:27 AM

Quote:

Originally Posted by KevinH (Post 3202042)
Hi,
If you are talking about prettyprint gumbo, then yes Sigil will do that. If you don't want Sigil to prettyprint then change your preferences to use just gumbo.

KevinH

Thanks

JeffJ 11-09-2015 08:11 AM

Quote:

Originally Posted by KevinH (Post 3202351)
Are you setting your Preferences to clean on Open or Save and if so are you telling it to use PrettyPrint or not? If so, do not use PrettyPrint Gumbo. Use normal Gumbo which makes fewer changes.

'Automatically Clean and Format HTML Source Code' has both Open and Save checked.
'When Cleaning, Use This Type' is set to 'Pretty Print Gumbo'.

If 'Google Gumbo-Parser' is selected the extra line isn't added.

DiapDealer 11-09-2015 08:34 AM

Quote:

Originally Posted by JeffJ (Post 3202700)
'Automatically Clean and Format HTML Source Code' has both Open and Save checked.
'When Cleaning, Use This Type' is set to 'Pretty Print Gumbo'.

If 'Google Gumbo-Parser' is selected the extra line isn't added.

I don't think I was paying close-enough attention to what you were saying. Are you saying that Pretty-Print causes ToC titles to be truncated (when using Generate Table of Contents) where Gumbo-Parser does not? I'm not seeing that in my tests with your sample. I do see the newlines being included in the Table of Contents widget and in the NCX (which may or may not be be problematic by itself), but no truncation is happening for me.


All times are GMT -4. The time now is 08:14 PM.

Powered by: vBulletin
Copyright ©2000 - 3.8.5, Jelsoft Enterprises Ltd.
MobileRead.com is a privately owned, operated and funded community.