MobileRead Forums - New Sigil Release: Sigil-0.8.901

Hi,

Most of the warnings I see not in the 3rdparty section of the source, are related to:

Code:

 sizet n = length(of something);

 for (int i=0; i < n; i++) {

    blah;

}



or



int n = length(of something);

for (uint i = 0; i <n; i++) {

   blah;

}

where the only reason the uint is used to is try to get around warnigns from other compilers that used to complain in the reverse direction because the length of some objects may be size_t, int, unsigned int depending on platform and compiler used.

No n will be big enough for this to be an issue of overflow of the non-negative range of values of an int i and adding casts just make the code messy.

None of these are in any way real issues.

The only other warning type in your file is reorder warning as it does not like constructor member initialization lists to be in a different order than the order they are declared in the header for that class. AFAIK, none of these are bugs either. In the C++ spec, the order of initialization in the constructor has nothing to do with the order that members of a class are constructed, destructed, or initialized as that is solely determined by the order of their declaration in the header. So this is a warning about nothing, other than understand the C++ spec on the order of member initialization.

The only other warning type in your list is a unused variable warning that again is there becase of other code that is ifdef'd out at the moment but kept around. So nothing to see here either.

Nothing to worry about here.

Thanks,

KevinH

ps. I have just pushed changes to Sigil master to hopefully prevent these warnings. If you do another clean build any time soon please let me know if you see anything warningwize in Sigil.

Thanks!

Kevin

Quote:

Originally Posted by gbm (Post 3199209)

I just did a new build of Sigil--Linix Mint 17.2--and had a lot of:

Code:

warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Are they expected?
The build seems to work ok.

bernie