Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Calibre > Editor

Notices

Reply
 
Thread Tools Search this Thread
Old 08-03-2014, 11:10 AM   #1
arspr
None
arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.
 
Posts: 412
Karma: 245000
Join Date: Mar 2011
Location: Madrid, Spain
Device: Sony PRS-650 >>> Kobo Aura HD
Question A too strict decision? - Check Book with parsing errors

Hi Kovid, (and rest of users),

I've just noticed that because of this recent commit Check Book has stopped showing errors when critical parsing ones have been found. And I understand this is probably a needed tweak because, if you cannot properly "read" a book, what the hell are you going to say about its contents.

The problems I see with this decision:
  • Possibly habit, (because of the way Calibre has worked till now and therefore I'm used to the previous behaviour), but Calibre doesn't inform the user that it is not showing more errors/warnings/whatever because it has stopped performing tests, not because everything else seems perfect... Is it possible to explicitly tell the user that the tests have been aborted?
  • Different types of files and parsers. I mean, OK I've got troubles in a malformed CSS file, I understand that Calibre stops informing about that CSS file but why cannot it inform about warnings in any other CSS file? Or why cannot it inform about warnings or other errors in html or opf files which are not affected about that malformed CSS file? Or about the book containing the Calibre bookmarks file?
  • Maybe some parsing errors are not so critical for other tests within the same file? In the recent book I sent you because of the Live CSS issues I posted in launchpad, there are a lot of parsing errors in its CSS file because of:
    Code:
     border-width: 1;
    I mean that a lot of styles lack measurement unit in that property. Is not CSS spec supposed to say that wrong lines (un-parsable) should be ignored?
    Another example: imagine an html file with parsing errors (typically missing ending tags), why should the too-big-HTML-file warning be blocked? (Fixing the parsing errors is not probably going to really affect the approximate global size of the file).

As a summary: maybe your decision is fully right, but I think that there's some room for improvement around it: 1st) the user should be explicitly notified, and 2nd) this abortion doesn't need to be absolute but specifically chosen on really affected secondary tests.
arspr is offline   Reply With Quote
Old 08-03-2014, 11:33 AM   #2
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 26,117
Karma: 5101571
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
I am not going to maintain a list of all possible secondary tests that fail on all possible individual parsing errors, that is way too much work. If your book has parsing errors, then fix those errors first and re-run check book.

Since it makes absolutely no sense to not re-run check book after fixing errors (other wise how do you know the error was actually fixed) I dont see the problem.

And the check should not be aborted after css errors, that was an oversight.
kovidgoyal is offline   Reply With Quote
Old 08-08-2014, 06:11 PM   #3
arspr
None
arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.
 
Posts: 412
Karma: 245000
Join Date: Mar 2011
Location: Madrid, Spain
Device: Sony PRS-650 >>> Kobo Aura HD
Kovid, I'm suffering a possible bug.

The "named entities" warning is fully masking "CSS unknown property name" warning and "Calibre bookmark file" info. I need to solve the former one or the other two are not shown.
arspr is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Epub check Errors, Help Please shampaynes ePub 6 12-17-2010 06:08 AM
How do you check a book for errors? Davimee Astak EZReader 12 10-05-2010 01:39 PM
Epub Check Errors (loads!) ghostyjack ePub 5 09-03-2010 08:34 AM
errors after epub check ericp20 Sigil 2 06-13-2010 10:40 AM
Does it have to be XHTML 1.1 Strict? AlexBell ePub 7 07-18-2009 07:51 AM


All times are GMT -4. The time now is 07:04 PM.


MobileRead.com is a privately owned, operated and funded community.