|
|
#1 |
|
Member
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 10
Karma: 60292
Join Date: May 2013
Device: Nexus 7
|
[Metadata Source Plugin] Comicvine
Check out the code on Github Main Features of v0.10.0
Coming Soon:
Installation Notes:
Past Versions: Spoiler:
Last edited by chewt0y; 06-16-2013 at 05:51 AM. Reason: New version released |
|
|
|
|
|
#2 |
|
Creator of calibre
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 22,660
Karma: 3473290
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
@chewtoy: You would make life simpler for your users if you bundled pycomicvine in the plugin zip file. Then they wont need to do a separate dependency install.
__________________
Get calibre Notice to all: I can not provide assistance with DRM removal, for legal reasons, so please do not contact me about it. |
|
|
|
|
Enthusiast
|
|
|
|
#3 |
|
Member
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 10
Karma: 60292
Join Date: May 2013
Device: Nexus 7
|
@kovidgoyal - Thanks for the suggestion. I had been considering doing that. I have just updated with a new version that includes the pycomicvine code.
|
|
|
|
|
|
#4 | ||
|
Zealot
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 107
Karma: 2800
Join Date: Jul 2010
Location: Australia
Device: iPad2, Kindle 4 NT
|
Hey, I'm getting an error trying to install this, something about simplejson
Quote:
Quote:
Any ideas? Last edited by Aleyst; 05-19-2013 at 03:02 AM. |
||
|
|
|
|
|
#5 |
|
Member
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 10
Karma: 60292
Join Date: May 2013
Device: Nexus 7
|
I guess adding pycomicvine to the package didn't make it as standalone as I thought.
This error is showing that you need the simplejson module for python installed. I will see what I can do to either remove the external dependencies or bundle them in the plugin distribution, but in the mean time you should be able to fix this by installing the "simplejson" and 'python-dateutil' modules. I can't tell which OS you are running under. On a debian / ubuntu based box you can get everthing installed using: sudo apt-get install python-simplejson python-dateutil For a more generic method you can use the instructions here to setup easy_install (part of the setuptools package) http://pythonhosted.org/distribute/easy_install.html Then you can use: easy_install simplejson easy_install dateutil Sorry for the inconvenience, I'll try and get a fixed version out ASAP. Last edited by chewt0y; 05-24-2013 at 06:32 AM. |
|
|
|
|
|
#6 |
|
Creator of calibre
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 22,660
Karma: 3473290
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
dateutil is bundled with calibre, as for simplejson, the python stdlib has a json module, so there should be no need to use a third party one.
__________________
Get calibre Notice to all: I can not provide assistance with DRM removal, for legal reasons, so please do not contact me about it. |
|
|
|
|
|
#7 |
|
Member
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 10
Karma: 60292
Join Date: May 2013
Device: Nexus 7
|
Yes, the setup.py file lists dateutil 2.0.0 as a dependency, whereas calibre is currently packaged with 1.5 - but from a quick look at the code it seems to be compatible even though the dependency says otherwise.
As for simplejson, I have just pushed out 0.8.2 which uses the bundled json module rather than simplejson - it seems to do the job fine, so no need to bundle simplejson in the plugin
|
|
|
|
|
|
#8 |
|
Member
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 10
Karma: 60292
Join Date: May 2013
Device: Nexus 7
|
I have just pushed out 0.8.2 of the plugin.
This modifies the bundled pycomicvine to use the library json module rather than the external simplejson. I was concerned that the version of dateutil bundled with calibre would be too old (latest version has 1.5), as the setup.py file for pycomicvine lists 2.0.0 as required; however I have run some tests using 1.5 and it seems to be fine, so looks like fixing this was a simple one-line patch
|
|
|
|
|
|
#9 |
|
intelligent posterior
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,082
Karma: 12040848
Join Date: Mar 2009
Location: Ohiopolis
Device: Nook HD+ (rooted), Nook Color (CM10)
|
I got similar errors as others listed above when trying to install, but restarted Calibre in debug mode and was able to install the plugin. Now, I'm getting the following error when trying to configure the plugin:
Code:
calibre, version 0.9.34 ERROR: Unhandled exception: <b>AttributeError</b>:'ConfigWidget' object has no attribute 'label' Traceback (most recent call last): File "site-packages\calibre\gui2\preferences\plugins.py", line 288, in customize_plugin File "site-packages\calibre\gui2\preferences\plugins.py", line 364, in modify_plugin File "site-packages\calibre\customize\__init__.py", line 150, in do_user_config File "calibre_plugins.comicvine.source", line 42, in config_widget File "calibre_plugins.comicvine.config", line 31, in __init__ AttributeError: 'ConfigWidget' object has no attribute 'label'
__________________
|
|
|
|
|
|
#10 |
|
intelligent posterior
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,082
Karma: 12040848
Join Date: Mar 2009
Location: Ohiopolis
Device: Nook HD+ (rooted), Nook Color (CM10)
|
Has anyone had success with this plugin? Chewt0y, is it working for you? I tried uninstalling and reinstalling (not in debug mode, and no install errors this time), but got the same error when trying "customize plugin."
__________________
|
|
|
|
|
|
#11 |
|
Watching the Sky
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 100
Karma: 347380
Join Date: Sep 2012
Location: Winnipeg, MB
Device: Kobo Glo
|
Get the following error when trying to configure (Mac OS X 10.8.4, calibre 0.9.34 and v0.9.1 the plugin):
Code:
calibre, version 0.9.34 ERROR: Unhandled exception: <b>AttributeError</b>:'ConfigWidget' object has no attribute 'label' Traceback (most recent call last): File "site-packages/calibre/gui2/preferences/plugins.py", line 285, in double_clicked File "site-packages/calibre/gui2/preferences/plugins.py", line 364, in modify_plugin File "site-packages/calibre/customize/__init__.py", line 150, in do_user_config File "calibre_plugins.comicvine.source", line 42, in config_widget File "calibre_plugins.comicvine.config", line 31, in __init__ AttributeError: 'ConfigWidget' object has no attribute 'label' |
|
|
|
|
|
#12 |
|
Watching the Sky
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 100
Karma: 347380
Join Date: Sep 2012
Location: Winnipeg, MB
Device: Kobo Glo
|
I've forked the repo and commited a few changes that fix the problem.
|
|
|
|
|
|
#13 |
|
intelligent posterior
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 1,082
Karma: 12040848
Join Date: Mar 2009
Location: Ohiopolis
Device: Nook HD+ (rooted), Nook Color (CM10)
|
Looks like the same issue I'm having in Windows. If you can shoot me a Calibre-ready zip w/ your changes I'd be happy to test it out.
__________________
|
|
|
|
|
|
#14 |
|
Member
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 10
Karma: 60292
Join Date: May 2013
Device: Nexus 7
|
I have just fixed this, and am about to upload here. buffaloseven - I'll take a look at your fix as well. I'm not a gui guy, so my fix isn't particularly pretty
|
|
|
|
|
|
#15 |
|
Member
![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() ![]() Posts: 10
Karma: 60292
Join Date: May 2013
Device: Nexus 7
|
OK. I have just pushed another update (0.9.3) which has a better layout for the config screen (my original solution was very similar to buffaloseven's).
Sorry for the delay replying, by the way. Mea culpa. I have now changed my subscription details for this thread so that I'll get updates straight away rather than weekly batched updates... |
|
|
|
![]() |
| Thread Tools | Search this Thread |
|
Similar Threads
|
||||
| Thread | Thread Starter | Forum | Replies | Last Post |
| [Metadata Source Plugin] Goodreads | kiwidude | Plugins | 157 | 05-07-2013 02:34 PM |
| [Metadata Source Plugin] LubimyCzytac [PL] | jbienko1 | Plugins | 15 | 03-03-2013 05:27 PM |
| [Metadata Source Plugin] Skoob | rodrigoccurvo | Plugins | 7 | 12-19-2012 08:27 PM |
| [Metadata Source Plugin] BIBLIOETECA | biblioeteca | Plugins | 3 | 10-18-2012 04:42 AM |
| [Metadata Source Plugin] Amazon.it | nandocuci | Plugins | 2 | 05-18-2011 02:36 AM |