[GUI Plugin] Kindle Collections (old)

[eschwartz]

NiLuJe, are you updating this plugin for the qt5 betas?

Also, maybe this would be a good time to get KC a new thread owned by you to support both versions -- now that the old one needs to go anyway?

[NiLuJe]

@eschwartz: That's certainly on the horizon, if Qt5 doesn't drive me mad in the process .

(And yeah, I agree that it would be a perfect opportunity to take maintainer-ship of the plugin)

[eschwartz]

Originally Posted by NiLuJe

@eschwartz: That's certainly on the horizon, if Qt5 doesn't drive me mad in the process .

(And yeah, I agree that it would be a perfect opportunity to take maintainer-ship of the plugin)

I am open to testing it.

[NiLuJe]

@eschwartz: Good to know, thanks .

(But the initial stages will probably consist of me making stuff up and hoping it works ;D).

[6EQUJ5]

@NiLuJe porting to qt5 ist as easy as running search & replace on "PyQt4" -> "PyQt5".
I just did that and everything seems to be working perfectly so far

If you take maintainership please upload this thing somewhere decent, like github or bitbucket. I don't really care where. That would just make contributing a lot easier.

~ Have a nice day

[NiLuJe]

@6EQUJ5: Thanks, I'll probably do it in the coming week. (FWIW, I'm using SVN internally, so I'm good on the keeping track of stuff front ;p).

[6EQUJ5]

@NiLuJe doesn't help the community much :/
At least keeping track of stuff is always good

[NiLuJe]

@6EQUJ5: Agreed, but on the other hand, you're the first one to show interest on that front in over a year . (Granted, there may also be a chicken/egg effect at play here ^^).

[6EQUJ5]

@NiLuJe: Well, this is the first time this plugin broke for me, so I just went ahead and fixed it :P
Then I was searching for where to send my changes, so other people can benefit.
I don't plan to contribute to this project as in actively developing. It's just anywhere something breaks in my daily usage, I fix it myself (at least if I am able to) and push it back upstream.

I guess it is not really necessary, but it would just ease things for people like me and the development is more transparent, which I am both a fan of :P

[NiLuJe]

@6EQUJ5: We have a few projects like this on MR with very few activity where we usually fall back to posting patches in the project's thread .

[6EQUJ5]

Originally Posted by NiLuJe

@6EQUJ5: We have a few projects like this on MR with very few activity where we usually fall back to posting patches in the project's thread .

If it works well, that's fine by me

The reason I didn't post a patch is that it's very easy to do and I just explained how it can be done :P

meme, the creator of this plugin is inactive I understand?

[NiLuJe]

@6EQUJ5: Yeah, no worry, that's good enough for me, that was just to give you some context as to why I never bothered making the repo more widely accessible .

And yeah, meme is inactive; I'll probably ask for maintener-ship more properly with the Qt5 switch, that'll be easier on everyone.

[eschwartz]

I've ported the imports over to Qt5 as per Kovid's sticky, and reloaded the plugin. It seems to be working just fine. Nothing else needed.

(Extra confirmation. )

[NiLuJe]

@eschwartz: The most UI-heavy thing is the manual collection edit screen, so if that works, everything should be good .

[NiLuJe]

I ported the tweaked version.

Only tested on PyQt4 so far, but the only tricky thing different from the upstream version was a QVariant that needed to be taken care of, and the potential issues are mostly on the PyQt4 side with this.