[GUI Plugin] Quality Check

[kiwidude]

Thx folks for the support - sounds like we have a winner.

@theducks - the existing checks in this plugin define a "calibre cover" based on certain metadata being configured in the opf manifest. It has nothing to do with the actual source of the image, just purely about whether a calibre conversion has been done on that epub at some point resulting in the cover being identifiable in a specific way.

The new "Check replaceable cover" option changes this logic. Instead it is all about whether the cover image is defined in the epub in such a way that calibre "could" replace it. It is being done in exactly the same way as the actual calibre code does when you choose save to disk/send to device. So it should take the guesswork out of the lottery that takes place when you don't know if your library cover will "stick" in the epub or not, regardless of whether you have converted that epub with calibre in the past.

[theducks]

@Kiwidude

for the info

[kiwidude]

Changes in this release:

• Add "Check replaceable cover" and "Check non-replaceable cover" checks to indicate whether a cover can be replaced when exported/using Modify ePub to update metadata
• Remove the "Check inline Calibre cover" and "Check not inline Calibre cover" checks since replaceable cover checks are more useful
• Improve the exception messages for invalid epubs to include the reason

[jackie_w]

Originally Posted by kiwidude

The new "Check replaceable cover" option changes this logic. Instead it is all about whether the cover image is defined in the epub in such a way that calibre "could" replace it. It is being done in exactly the same way as the actual calibre code does when you choose save to disk/send to device. So it should take the guesswork out of the lottery that takes place when you don't know if your library cover will "stick" in the epub or not, regardless of whether you have converted that epub with calibre in the past.

I've tried the new 'check non-replaceable cover' option. The results lead me to believe I don't really understand what conditions need to be met to make it 'non-replaceable'. Is it possible you could try and explain in simple(-ish) terms?

I'm guessing that one of them is absence of <meta name="cover" content="..." /> in the opf file.

Also is it a series of 'and' conditions or 'or' conditions.

[kiwidude]

The reason why an epub's cover is not replaceable will be displayed in the log. It will usually be one of the following three messages:

No supported meta tag or non-xml cover
A cover must have a <meta name="cover" content="xxx/> defined in the opf manifest. Even if this tag is defined, the manifest item that it is linked to must be an image as defined by the media-type of the manifest item. It cannot be an xml file as some svg covers are.

DRM encrypted cover
If an epub has DRM encryption, and the encryption.xml file indicates that the encryption also applies to the cover image, then it cannot be replaced.

Invalid cover image extension
Looking at the filename extension of the image file itself, does it end in .jpg, .jpeg or .png, as these are the only image formats calibre's logic supports replacing.

In the case of the "Check non-replaceable covers", failing any of these conditions means the ePub will appear in the results.

In the case of "Check replaceable covers", it must pass all of these conditions to appear in the results.

[jackie_w]

OK, thanks, I think I understand that. The few epubs I tried had the first error message.

[paulfiera]

@kiwidude: I am running the "Check broken images links" option and something seems to have changed in the latest version.

Previously, the log - which I save to a text file - used to be sorted in the same way I had sorted my library: by Authors, by Titles, and so on. Now the results are not sorted at all.

I'm using Library as scope.

Many thanks

[kiwidude]

@PaulFiera - No changes have been made to that logic in forever. There is no ordering applied to either the processing or the displaying of the results by this plugin.

[paulfiera]

Originally Posted by kiwidude

@PaulFiera - No changes have been made to that logic in forever. There is no ordering applied to either the processing or the displaying of the results by this plugin.

Thanks, kiwidude.

I may have found the reason. I had excluded three books from this check because the referenced images are in svg format - "Images/page0129_0000.svg" - and even though the images exist in this format and are correctly displayed, they were flagged as broken links.

I removed the three books from the exclusions and now the sorting works as before.

[kiwidude]

Ahhhh... now the penny drops. Yes I do some set operations if you have exclusions and that will "fiddle with" the ordering. I don't explicitly specify an ordering in this plugin, but it seems that one circumstance will "break" any ordering that was applied. I will see if I can find a better way of doing that so that such ordering is preserved.

Whats the deal with the .svg links that had you excluding them, that sounds like a possible bug? Any chance you can PM me a link to one of the books (or email me - my address is in the code)?

[paulfiera]

PM sent

[kiwidude]

Changes in this release:

• Fix some casing of various menu items for consistency
• Fix for "Check unused image files" to include svg and bmp files as a possible image type
• Change the handling of exclusions to ensure that ordering of the books is preserved
• Add a "Check clipping limit" option to the Check Mobi menu for files that are limited in the % of book that can be clipped on a Kindle

[paulfiera]

Many thanks, kiwidude.

Working perfectly now

[paulfiera]

Originally Posted by kiwidude

Changes in this release:

• Add "Check replaceable cover" and "Check non-replaceable cover" checks to indicate whether a cover can be replaced when exported/using Modify ePub to update metadata

It may well be that I don't fully understand this option. Running it against my library with 4.080 books, it returns 3.966 matches for "Check replaceable cover".

What does this really mean? I've edited most of these books and the covers look OK to me. They are the covers I've chosen editing the metadata.

[theducks]

Originally Posted by paulfiera

It may well be that I don't fully understand this option. Running it against my library with 4.080 books, it returns 3.966 matches for "Check replaceable cover".

What does this really mean? I've edited most of these books and the covers look OK to me. They are the covers I've chosen editing the metadata.

as I understand:
Those are the books that will GET the latest metadata cover when sent to a device. (you seem to have about 120 that won't)