iLiad Improved contenLister (with installer)

[Shaggy]

There's an option in the settings that tells the iLiad to open the most recent document after it boots. Is that what this is related to?

[hansel]

Originally Posted by Shaggy

There's an option in the settings that tells the iLiad to open the most recent document after it boots. Is that what this is related to?

O.K. That might be it...
But If the last thing you do before rebooting is installing software? Will it install again? If so install scripts should probably remove themselves from the 'recent items' list...

Back to the drawing board

[hansel]

Originally Posted by Shaggy

There's an option in the settings that tells the iLiad to open the most recent document after it boots. Is that what this is related to?

O.K. That might be it...

But If the last thing you do before rebooting is installing software? Will it install again after the reboot? If this is the case it is probably a potential problem in other install scripts as well... If so install scripts should probably remove themselves from the 'recent items' list...

It's a good thing that there's no such thing as negative karma points

Back to the drawing board
EDIT: shaggy: this is indeed what happens. For those interested: It all happens in contenLister/src/control.c:

1. ctrl_start_up_behaviour()
2. startup_idle_handler()
3. ctrl_open_last_read_document()
4. ctrl_listItem_clicked()
5. ctrl_start_application()

[Shaggy]

It should be possible to add a check to ctrl_open_last_read_document() that makes sure the most recent document is not a script. I would have thought it did that already... guess not.

[hansel]

Update:

I have updated the install scripts, so that they do not appear in "Recent Documents'. This avoids the problem mentioned by henryhu and ne14st. Thanks for reporting it. shaggy: thanks for identifying the cause.

The following has been added to the common part of the install scripts. Maybe it's useful in other scripts...

#remove this script from 'Recent Documents'`
RECENT=/var/recentdocuments/
HERE=`pwd`
LINK=$RECENT`(ls -l $RECENT | grep $HERE | awk '{print $9}')`
if [ ! $LINK = $RECENT ]; then
  rm $LINK
fi

[henryhu]

It's much better, it can be the official release now.

hansel,
You are master.

[Mr. Goodbar]

It we did the modification via the original method of copying the files over what needs to be done to correct the potential problem. I've been using the original process without any problems.

[-Thomas-]

@Mr. Goodbar: I think you should be fine to replace the newLister-x.x.x directory on your memory card with the new version hansel attached to his first post. A re-installation of the newLister should not be necessary.

To all contentLister hackers out there: In hsStoreItem() in history.c there is a snippet that assures that png files are not added to the history:

if (    item->fit == mdsFitFile
            &&  strcasecmp(item->szFileExt, "png") == 0 )
        {
            // Notes template: do not add to recent documents
            CL_WARNPRINTF("Notes template: file [%s] not added to recent documents", item->szFilename);
        }
        else
        {
            hsAddRecent(item);
        }

Maybe we can change it to also cover .sh files in the future?

[hansel]

Originally Posted by -Thomas-

@Mr. Goodbar: I think you should be fine to replace the newLister-x.x.x directory on your memory card with the new version hansel attached to his first post. A re-installation of the newLister should not be necessary.

Indeed. But re-installing does no harm...

Originally Posted by -Thomas-

Maybe we can change it to also cover .sh files in the future?

I think it would not work here: since the the scripts are in a directories with a manifest.xml, it's the directory that is recorded; not the script itself...

Besides: if we block all shell scripts form 'recent documents', it will become impossible to start anything from there (I always start sshd from 'recent documents').

[quek]

Great job hansel! Works perfectly!

[kapoira]

i think that the content listener try to execute another time the script because you have chosen that the content listener open the last page of your documents and not a view of a directory or the recent documents.

I'm thinking this is the problem that somebody have and not hansel.

[nekokami]

W00t! So nice to finally have this fixed.

Now if we could just get ability to sort by different criteria into ContentLister....

[zerospinboson]

Request: Could you make the font used when displaying 12 items 1pt smaller, and add file size info (i don't care in what font size as long as i can make it out) to the right end of the 2nd line?

[romanas]

@hansel: i modified firmware script and changed 2.12 into 2.12.1 It works fine now. Thank you very much, great job

[hansel]

Originally Posted by romanas

@hansel: i modified firmware script and changed 2.12 into 2.12.1 It works fine now. Thank you very much, great job

Thanks for testing.
newLister-1.0.4 accepts all versions that contain 2.12:

old test: if [ "$Firmware_iLiad" = "$Firmware_Script" ]; then  
new test: if echo $Firmware_iLiad | grep $Firmware_Script - ; then