proceed_question View Log Button Opens Dups

JimmXinu · 01-02-2020, 03:01 PM

This is a pretty minor issue I stumbled across:

When the gui.proceed_question() dialog is called, clicking the 'View Log' button more than once will pop multiple copies of the ViewLog dialog.

I do pass a log_viewer_unique_name to gui.proceed_question(), but it appears to only be used to save/fetch geometry for ViewLog.

I can see this in Calibre v4, v3 and v2. (I didn't test earlier.)

Again, I think this is pretty minor, but thought I should mention it.

Happy New Year!

kovidgoyal · 01-02-2020, 08:09 PM

Yeah, is there some reason it should not? I have not bothered implementing the logic to make it persistent/unique, do you have some functionality that relies on it?

JimmXinu · 01-02-2020, 11:17 PM

Nope. Just noticed it when I accidentally double clicked the button.

01-02-2020, 03:01 PM	#1
JimmXinu Plugin Developer Posts: 6,328 Karma: 3966249 Join Date: Dec 2011 Location: Midwest USA Device: Kindle Paperwhite(10th)	proceed_question View Log Button Opens Dups This is a pretty minor issue I stumbled across: When the gui.proceed_question() dialog is called, clicking the 'View Log' button more than once will pop multiple copies of the ViewLog dialog. I do pass a log_viewer_unique_name to gui.proceed_question(), but it appears to only be used to save/fetch geometry for ViewLog. I can see this in Calibre v4, v3 and v2. (I didn't test earlier.) Again, I think this is pretty minor, but thought I should mention it. Happy New Year!

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
'Add Books' Button: Control which File Manager opens?	andrew.46	Library Management	2	07-21-2018 11:12 PM
No 'Refresh View' button/function?	badbob001	Library Management	9	03-02-2015 05:05 PM
Metadata view log error	Gunnerp245	Calibre	2	04-07-2013 08:50 AM
book view window opens at bottom of text	cybmole	Sigil	2	01-14-2011 12:35 PM
Link button in table of contents view?	devseev	enTourage Archive	3	04-18-2010 08:47 PM

01-02-2020, 08:09 PM	#2
kovidgoyal creator of calibre Posts: 43,860 Karma: 22666666 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Yeah, is there some reason it should not? I have not bothered implementing the logic to make it persistent/unique, do you have some functionality that relies on it?

01-02-2020, 11:17 PM	#3
JimmXinu Plugin Developer Posts: 6,328 Karma: 3966249 Join Date: Dec 2011 Location: Midwest USA Device: Kindle Paperwhite(10th)	Nope. Just noticed it when I accidentally double clicked the button.