05-19-2012, 10:44 AM | #466 |
calibre/Sigil Developer
Posts: 4,601
Karma: 2092290
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
@GRiker - just a case of running the "Check broken image links" check against your library, and casting your eye down the log output to see if you have more books on there than you expect. For instance if you have loads of "titlepage.xhtml" missing their "cover.jpeg" (which seemed to be loximuthal's most common issue in the log I saw) then a quick sample of a couple of the books should show whether that is valid or it is reporting false positives as claimed
|
05-19-2012, 11:01 AM | #467 |
Grand Sorcerer
Posts: 12,117
Karma: 73448614
Join Date: Nov 2007
Location: Toronto
Device: Nexus 7, Clara, Touch, Tolino EPOS
|
|
05-19-2012, 04:46 PM | #468 |
Connoisseur
Posts: 81
Karma: 86158
Join Date: Jan 2011
Location: Maryland
Device: NST, Kindle Fire, iPad2
|
@kiwidude
Here's the log, check run on selection (your test) only: Spoiler:
And on my book only, the one I sent you, there are no broken images found. Also, sorry about the confusion on the log I sent. It was the check run against my whole library. Just not being very careful. |
05-19-2012, 05:10 PM | #469 |
calibre/Sigil Developer
Posts: 4,601
Karma: 2092290
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
Thx loximuthal. So as expected that log above shows the same as everyone else, i.e. absolutely no issue.
Which means there must be a problem with those epubs in your log that you think are false positives. I need you to PM me a link to one of those that you think is an example of that (completely unmodified, copy it direct out of the calibre folder). |
05-19-2012, 06:03 PM | #470 | |
Connoisseur
Posts: 81
Karma: 86158
Join Date: Jan 2011
Location: Maryland
Device: NST, Kindle Fire, iPad2
|
Quote:
If you like I can make a new epub the same way I did the others, but not do the "clean up" in Sigil I usually do. Or send you one of the other two that are still being caught. |
|
05-19-2012, 06:13 PM | #471 |
calibre/Sigil Developer
Posts: 4,601
Karma: 2092290
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
@loximuthal, I'm utterly confused.
The epub you sent me has no issues with it. You then said above "the one I sent you, there are no broken images found". So you agree with me. So what was the point of sending me that epub? The log file you sent me, has that same epub name in it showing a whole bunch of missing images, which I "presumed" was why you had picked it out to send to me. However the log is showing missing images for files which are not in the epub you sent me. So clearly you ran that check against a different version of the epub. So... either you have an epub which you think is a false positive on the report, or you don't. And if you do, that's what I need you to send me. |
05-20-2012, 07:06 AM | #472 |
Connoisseur
Posts: 81
Karma: 86158
Join Date: Jan 2011
Location: Maryland
Device: NST, Kindle Fire, iPad2
|
@kiwidude, I'll join you in confusion. When I ran the check originally it was against my whole library. In my initial post here I quoted only the lines directly relevant to one book, as an example. What I neglected to do, mostly because I had not remembered the scope option, was to run the check against one book and provide the full log for that. At that point the PI was catching a whole lot of books, most with one or two 'broken' images. That was the log that I PM'ed you which apparently you (quite reasonably) took to be the log for the single book I had also PM'ed you.
When you posted the debug version of the PI I installed it and followed your instructions to run the check against the test book. Which, as you noted, found exactly what you expected. Then I ran it against the book I had PM'ed you and forwarded that log. The only difference that I can tell is that when I ran the check with the non-debug PI it finds a problem but the debug version does not. Which I'm sure makes even less sense to you than it does to me. I'll try re-installing the non-debug version of the PI and run it on that book only, and let you know what happens. |
05-20-2012, 07:17 AM | #473 |
Connoisseur
Posts: 81
Karma: 86158
Join Date: Jan 2011
Location: Maryland
Device: NST, Kindle Fire, iPad2
|
non-debug version of PI:
Code:
The Monkey's Wedding / Joan Aiken Broken image link in: OEBPS/Text/titlepage.xhtml of ../images/cover.jpeg restarting calibre each time installing a different version of the PI. Both checks are against the same book only that I PM'ed you before. I hope you can make sense of this, 'cause it's got me all messed up. |
05-20-2012, 09:08 AM | #474 |
calibre/Sigil Developer
Posts: 4,601
Karma: 2092290
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
Quality Check next version beta
Hmmm... so it sounds to me like something I changed in the debug version fixed things for you. I did make a few tweaks, one to do with paths that I wouldn't have thought needed doing but perhaps it did.
Here is a version I will release next with the logging ripped out and the addition of an icon in the menu to see at a glance what scope is currently set without diving into the submenu. Give this a whirl and confirm you are still happy with it doing the right thing. Last edited by kiwidude; 05-20-2012 at 11:49 AM. Reason: Removed attachment as latest version officially released |
05-20-2012, 11:31 AM | #475 |
Connoisseur
Posts: 81
Karma: 86158
Join Date: Jan 2011
Location: Maryland
Device: NST, Kindle Fire, iPad2
|
That did the trick. Only three matches now: one is your test book, and the other two are mine and definitely have image problems. In both cases the image is visible in the book so I was surprised when the books were caught by the check initially. Looking carefully at the files I figured out why your check said the images were not actually in the book: they are stored on a website, and not within the book itself. I'll be bringing those images down and sticking them into the books so they are local.
Thanks! |
05-20-2012, 11:51 AM | #476 |
calibre/Sigil Developer
Posts: 4,601
Karma: 2092290
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
v1.8.4 Released
Changes in this release:
|
05-20-2012, 05:06 PM | #477 |
Resident Curmudgeon
Posts: 73,645
Karma: 127838196
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
Speaking of covers, can you add a check if the cover will display in iBooks and if not, fix the OPF so it does?
Also, could you check the CSS and find all the CSS styles that are not used and delete them? Also, what would be good is to allow quality check to check for a number of things at the same time instead of having to run it over and over for each check. Last edited by JSWolf; 05-20-2012 at 05:32 PM. |
05-20-2012, 05:28 PM | #478 |
Resident Curmudgeon
Posts: 73,645
Karma: 127838196
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
I've just managed to get Quality Check to blow up...
Spoiler:
|
05-20-2012, 06:14 PM | #479 | ||||
calibre/Sigil Developer
Posts: 4,601
Karma: 2092290
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
|
Quote:
Quote:
Quote:
Think about the issues involved - lets say you select 10 books and run 5 checks against them, and get all sorts of permutations of issues with those books. How on earth are you going to clean them up in a meaningful way knowing what was wrong with each book? At its crudest it would have to be a log file listing by book all the things found wrong with it perhaps (and the search shown at the end are all the books that had "something" wrong). That leaves the onus on the user to copy that log text to notepad and have it open side by side while they go through and fix stuff, selecting different combinations of books manually if they are using Modify ePub to do so. It's a bit icky really. However there is no doubt that if you have a certain "set" of checks that you think are appropriate for your library, and you want to sanity check either your whole library or books added since a certain date every now and then, that being able to bulk run like this would be less painful than individually running them all. So it will happen one day, it just needs some thought on how it should work. Quote:
|
||||
05-20-2012, 06:24 PM | #480 | ||
Resident Curmudgeon
Posts: 73,645
Karma: 127838196
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
Quote:
Quote:
Last edited by DoctorOhh; 05-20-2012 at 09:53 PM. Reason: added opening quote |
||
Thread Tools | Search this Thread |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
[GUI Plugin] Search the Internet | kiwidude | Plugins | 423 | Today 06:53 AM |
[GUI Plugin] Open With | kiwidude | Plugins | 402 | 03-16-2024 11:44 PM |
[GUI Plugin] Clipboard Search | kiwidude | Plugins | 24 | 03-16-2024 11:06 PM |
[GUI Plugin] Kindle Collections (old) | meme | Plugins | 2070 | 08-11-2014 12:02 AM |
[GUI Plugin] Book Sync **Deprecated** | kiwidude | Plugins | 111 | 06-07-2011 07:47 PM |