Beta Test of new Kobo Driver

[dantaipan]

Thanks Tim, I tried the update unfortunately now I get this:

local variable 'ImageID' referenced before assignment

Traceback (most recent call last):
File "site-packages\calibre\gui2\device.py", line 58, in run
File "site-packages\calibre\gui2\device.py", line 308, in _delete_books
File "<string>", line 269, in delete_books
File "<string>", line 227, in delete_via_sql
UnboundLocalError: local variable 'ImageID' referenced before assignment

D

[timlegge]

Originally Posted by dantaipan

Thanks Tim, I tried the update unfortunately now I get this:

local variable 'ImageID' referenced before assignment

Traceback (most recent call last):
File "site-packages\calibre\gui2\device.py", line 58, in run
File "site-packages\calibre\gui2\device.py", line 308, in _delete_books
File "<string>", line 269, in delete_books
File "<string>", line 227, in delete_via_sql
UnboundLocalError: local variable 'ImageID' referenced before assignment

D

I saw that just today on a Windows machine that I have but the same delete worked fine on Linux. I will look into it but I don't have a build environment on Windows.

Tim

[JBlyth]

Sorry about the cross post - I thought this might better in this thread....

Deleting Kobo files from my Kobo Reader works nicely, but I get an error message when I try and delete an EPUB book.

I am using .7 and the June 1 Kobo driver. I don't seem to be able to copy the error to the clip board either. All I get when I paste is "Error Communicating with Device".

Many thanks
John in Sunny Carnarvon - Western Australia

[timlegge]

Originally Posted by JBlyth

Sorry about the cross post - I thought this might better in this thread....

Deleting Kobo files from my Kobo Reader works nicely, but I get an error message when I try and delete an EPUB book.

I am using .7 and the June 1 Kobo driver. I don't seem to be able to copy the error to the clip board either. All I get when I paste is "Error Communicating with Device".

Many thanks
John in Sunny Carnarvon - Western Australia

grab the latest version from the thread. I removed the old version so any you grab should be correct. There was a bug that I resolved yesterday related to not havind a sd card installed.

[JBlyth]

Originally Posted by timlegge

grab the latest version from the thread. I removed the old version so any you grab should be correct. There was a bug that I resolved yesterday related to not havind a sd card installed.

Hi Tim,

I got the version updated with the kobo_plugin.py file dated 06-06-10. Sadly the problem deleting the EPUB file remains the same. Just in case - I have no SD inserted.....

I note that when I use the original default plugin, I was able to delete EPUBs very nicely.....

Cheers - and the best of luck!
John

[timlegge]

Originally Posted by JBlyth

Hi Tim,

I got the version updated with the kobo_plugin.py file dated 06-06-10. Sadly the problem deleting the EPUB file remains the same. Just in case - I have no SD inserted.....

I note that when I use the original default plugin, I was able to delete EPUBs very nicely.....

Cheers - and the best of luck!
John

Hi

Is the message the same or are you now seeing a different problem.

Tim

[JBlyth]

Originally Posted by timlegge

Hi

Is the message the same or are you now seeing a different problem.

Tim

Same error message as posted earlier. Same line numbers etc....

Cheers
John

[timlegge]

Originally Posted by JBlyth

Same error message as posted earlier. Same line numbers etc....

Cheers
John

Hi

Did you remove the old version of the plugin? Also, if possible open the zip file, extract the kobo_plugin.py file and see if line 267 which references a sd card is commented out. It is possible that I uploaded the wrong version of the plugin again.

Tim

[JBlyth]

Originally Posted by timlegge

Hi

Did you remove the old version of the plugin? Also, if possible open the zip file, extract the kobo_plugin.py file and see if line 267 which references a sd card is commented out. It is possible that I uploaded the wrong version of the plugin again.

Tim

Hi Tim,

Yes, I started off from a complete new install, including removing the folders left in the AppData folder.

The line 267 does appear to be commented out....


ContentID = path
ContentID = ContentID.replace(self._main_prefix, "file:///mnt/onboard/")
# ContentID = ContentID.replace(self._card_a_prefix, "file:///mnt/sd/")
# print "ContentID: " + ContentID
ImageID = self.delete_via_sql(ContentID, ContentType)

Cheers
John

[timlegge]

Originally Posted by JBlyth

Hi Tim,

Yes, I started off from a complete new install, including removing the folders left in the AppData folder.

The line 267 does appear to be commented out....


ContentID = path
ContentID = ContentID.replace(self._main_prefix, "file:///mnt/onboard/")
# ContentID = ContentID.replace(self._card_a_prefix, "file:///mnt/sd/")
# print "ContentID: " + ContentID
ImageID = self.delete_via_sql(ContentID, ContentType)

Cheers
John

Okay, there is no way that should happen. I will take a look at it tonight.

Tim

[timlegge]

Originally Posted by dantaipan

Thanks Tim, I tried the update unfortunately now I get this:

local variable 'ImageID' referenced before assignment

Traceback (most recent call last):
File "site-packages\calibre\gui2\device.py", line 58, in run
File "site-packages\calibre\gui2\device.py", line 308, in _delete_books
File "<string>", line 269, in delete_books
File "<string>", line 227, in delete_via_sql
UnboundLocalError: local variable 'ImageID' referenced before assignment

D

I found the issue. You tried to delete a book that you copied to the device without ejecting the device first and reconnecting it. The driver relies on the kobo to correctly update its database with the required rows but that only happens with a disconnect.

I have added code to address the issue but it needs more review/testing before it is ready for a release. Maybe tomorrow night.

Tim

[JBlyth]

Originally Posted by timlegge

I found the issue. You tried to delete a book that you copied to the device without ejecting the device first and reconnecting it. The driver relies on the kobo to correctly update its database with the required rows but that only happens with a disconnect.

I have added code to address the issue but it needs more review/testing before it is ready for a release. Maybe tomorrow night.

Tim

Ah ha!

I was not aware of that small point - I will try and do better in future ;-)

I'm looking forward to the update....

Cheers
John

[JBlyth]

Hi Tim,

I tried again - but with a similar error code this time.

1. Added a Book to Calibre from Digital Editions
2. Sent it to the device
3. Removed the Koko Reader
4. Inserted the Kobo Reader
5. Tried a delete
6. Got this slightly different error message
7. Still can't copy the error to the clipboard....


Hope this helps....

Cheers
John

[JBlyth]

Stranger and Stranger....

It actually appears that the book has been deleted from the Kobo Reader's "database", but remains both on the Reader (physically) and the in Calibre database on the PC....

[Added later] However, it remains in the metadata.calibre file on the Kobo, I see

Hope this points you in the right direction, Tim.

Cheers
John

[timlegge]

I have attached a new version of the plugin to the first message in this thread (and deleted all the others). It seems to work on both Linux and Windows for my test cases (add-delete, add-eject-connect-delete, save books to disk)...

The only issue I currently know about is that the library does not update the on device status when you delete a book from the device.

If this resolves most outstanding issues I may take some time to simplify the code (I guess I will do that either way...

Changes in this are mostly related to path separators (linux vs Windows). I also added code to allow the delete to continue if a book is not found in the sqlite database (likely because it was deleted immediately after it was added or at least before the device was disconnected)

The path separator issue affected most of the issues. If you see any issues, it would be helpful to know which OS and what the calibre display showed the path to be for the file.
Tim