Feature Request(s)

[KarlG]

Oh I AM, but I'm also very open for easy shortcuts!

[KarlG]

Making progress...

[KevinH]

Looks good!

I can do that with no changes with both clip bar 1 and clip bar 2, resized and placed side by side.

If you do get something fully working on all platforms and it takes up no more extra vertical space (as height is the key constraint on a monitor - not width), we would be happy to review those changes as a pull request for merging into Sigil.

[KarlG]

I can get up to 40 clips on toolbar 1, but from clip41 nothing's showing on toolbar 2. Is there logic somewhere that I need to change?

[KevinH]

Yes in MainWindow.cpp It is what connects the actions defined in main.ui.
So make sure you have added new clip actions in main.ui first before moving to MainWindow.cpp. Try searching there for "clip" and one of the clip actions to see where changes might be needed as MainWindow.cpp is huge.

[BeckyEbook]

Yes. Add actionClip41 to actionClip80.
File \Form_Files\main.ui is crucial.

[KarlG]

Originally Posted by BeckyEbook

Yes. Add actionClip41 to actionClip80.
File \Form_Files\main.ui is crucial.

Yes, already done that. Added them to two separate places

menuClip2
Clip Bar2

[BeckyEbook]

This is not enough.
The third place is just as important (you're sure to track it down, look for "Insert Clip 40"):

Spoiler:

  <action name="actionClip41">
   <property name="text">
    <string>Clip 41</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 41</string>
   </property>
  </action>
  <action name="actionClip42">
   <property name="text">
    <string>Clip 42</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 42</string>
   </property>
  </action>
  <action name="actionClip43">
   <property name="text">
    <string>Clip 43</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 43</string>
   </property>
  </action>
  <action name="actionClip44">
   <property name="text">
    <string>Clip 44</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 44</string>
   </property>
  </action>
  <action name="actionClip45">
   <property name="text">
    <string>Clip 45</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 45</string>
   </property>
  </action>
  <action name="actionClip46">
   <property name="text">
    <string>Clip 46</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 46</string>
   </property>
  </action>
  <action name="actionClip47">
   <property name="text">
    <string>Clip 47</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 47</string>
   </property>
  </action>
  <action name="actionClip48">
   <property name="text">
    <string>Clip 48</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 48</string>
   </property>
  </action>
  <action name="actionClip49">
   <property name="text">
    <string>Clip 49</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 49</string>
   </property>
  </action>
  <action name="actionClip50">
   <property name="text">
    <string>Clip 50</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 50</string>
   </property>
  </action>
  <action name="actionClip51">
   <property name="text">
    <string>Clip 51</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 51</string>
   </property>
  </action>
  <action name="actionClip52">
   <property name="text">
    <string>Clip 52</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 52</string>
   </property>
  </action>
  <action name="actionClip53">
   <property name="text">
    <string>Clip 53</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 53</string>
   </property>
  </action>
  <action name="actionClip54">
   <property name="text">
    <string>Clip 54</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 54</string>
   </property>
  </action>
  <action name="actionClip55">
   <property name="text">
    <string>Clip 55</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 55</string>
   </property>
  </action>
  <action name="actionClip56">
   <property name="text">
    <string>Clip 56</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 56</string>
   </property>
  </action>
  <action name="actionClip57">
   <property name="text">
    <string>Clip 57</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 57</string>
   </property>
  </action>
  <action name="actionClip58">
   <property name="text">
    <string>Clip 58</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 58</string>
   </property>
  </action>
  <action name="actionClip59">
   <property name="text">
    <string>Clip 59</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 59</string>
   </property>
  </action>
  <action name="actionClip60">
   <property name="text">
    <string>Clip 60</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 60</string>
   </property>
  </action>
  <action name="actionClip61">
   <property name="text">
    <string>Clip 61</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 61</string>
   </property>
  </action>
  <action name="actionClip62">
   <property name="text">
    <string>Clip 62</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 62</string>
   </property>
  </action>
  <action name="actionClip63">
   <property name="text">
    <string>Clip 63</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 63</string>
   </property>
  </action>
  <action name="actionClip64">
   <property name="text">
    <string>Clip 64</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 64</string>
   </property>
  </action>
  <action name="actionClip65">
   <property name="text">
    <string>Clip 65</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 65</string>
   </property>
  </action>
  <action name="actionClip66">
   <property name="text">
    <string>Clip 66</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 66</string>
   </property>
  </action>
  <action name="actionClip67">
   <property name="text">
    <string>Clip 67</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 67</string>
   </property>
  </action>
  <action name="actionClip68">
   <property name="text">
    <string>Clip 68</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 68</string>
   </property>
  </action>
  <action name="actionClip69">
   <property name="text">
    <string>Clip 69</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 69</string>
   </property>
  </action>
  <action name="actionClip70">
   <property name="text">
    <string>Clip 70</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 70</string>
   </property>
  </action>
  <action name="actionClip71">
   <property name="text">
    <string>Clip 71</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 71</string>
   </property>
  </action>
  <action name="actionClip72">
   <property name="text">
    <string>Clip 72</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 72</string>
   </property>
  </action>
  <action name="actionClip73">
   <property name="text">
    <string>Clip 73</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 73</string>
   </property>
  </action>
  <action name="actionClip74">
   <property name="text">
    <string>Clip 74</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 74</string>
   </property>
  </action>
  <action name="actionClip75">
   <property name="text">
    <string>Clip 75</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 75</string>
   </property>
  </action>
  <action name="actionClip76">
   <property name="text">
    <string>Clip 76</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 76</string>
   </property>
  </action>
  <action name="actionClip77">
   <property name="text">
    <string>Clip 77</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 77</string>
   </property>
  </action>
  <action name="actionClip78">
   <property name="text">
    <string>Clip 78</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 78</string>
   </property>
  </action>
  <action name="actionClip79">
   <property name="text">
    <string>Clip 79</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 79</string>
   </property>
  </action>
  <action name="actionClip80">
   <property name="text">
    <string>Clip 80</string>
   </property>
   <property name="toolTip">
    <string>Insert Clip 80</string>
   </property>
  </action>

[KevinH]

Hmm ... I took a look at the MainWindow.cpp code and DiapDealer has greatly improved that code that handles clip actions to only depend on how many actions are defined in the main.ui, and even added a lambda function to assign slots.

That should take care of everything for MainWindow.cpp unless I am missing something (it has been a few years since I studied this code).

Are you sure you have assigned 40 actions to clip toolbar 1, and 40 newly defined actions to clip toolbar 2 in main.ui. Along with the changes to handling clip actions made by DiapDealer that really should get you close.

BeckyEbook's spoiler hint is correct.

You need to actually define what actions 41-80 are. Then assign them all to the second clips bar and the second clips menu.

[KarlG]

Thank you, found it.

Looking better now.

[KevinH]

Originally Posted by KarlG

Thank you, found it.

Looking better now.

Nicely done!

What happens if you now go to Sigil Preferences and grow the Icon size? Will the toolbars properly adjust and will you get the scroll indicator at the end of the toolbar? Does the scroll indicator at the end of the clip toolbar, interfere with using the clips at all?

[BeckyEbook]

The scroll indicator appears at the end of the bar. The bar expands downwards, obscuring a possible bar below. Selecting items once the bar has expanded is not easy, as you cannot go beyond the Clips Toolbar as you will lose the 'hover' and the bar will return to its default (shorter) state. But with the right toolbar layout, you can get used to it.

The scroll indicator is visible in the default light theme, but in dark mode it is not visible until you hover over it. I will try to track this down and find a solution.

[KevinH]

Originally Posted by BeckyEbook

The scroll indicator appears at the end of the bar. The bar expands downwards, obscuring a possible bar below. Selecting items once the bar has expanded is not easy, as you cannot go beyond the Clips Toolbar as you will lose the 'hover' and the bar will return to its default (shorter) state. But with the right toolbar layout, you can get used to it.

The scroll indicator is visible in the default light theme, but in dark mode it is not visible until you hover over it. I will try to track this down and find a solution.

Interesting, that was my big worry with having so many clips in one bar. Perhaps adding bar segments in groups of 10 clips? That way people could move and resize segments more easily?

I do not see a dark mode issue on macOS.

[KarlG]

This is what it looks like when I set the icon size to maximum

[KevinH]

Nice, since text, the clips icons are not growing.

What happens if you change the ui font size in Sigil Preferences to be bigger?