Two columns broken in 7.24

[pollito pito]

I know that maybe I’m the only one using calibre viewer as the only e-book reading application, so pardon me for asking.

I’ve been happily using the script I wrote sometime ago to read my e-books in two facing columns. But alas, something changed in the new 7.24. Now when I open an e-book, it displays the two columns and two seconds later removes them.

Can some of the developers please help me?

Thanks,
btw: There is substantial increase on the speed of the viewer…

[kovidgoyal]

the sequence of javascript library loading has changed. You will probably need to adjust your script to compensate. Now javascript is only loaded once the full page has finished loading rather than at the start (this was needed to upgrade jquery to the latest version, which in turn is responsible for the speedup).

[Lady Fitzgerald]

Btw, you aren't the only one to solely use calibre's viewer. It works fine for me (especially after Kovid tweaked it a bit several versions ago; thanks, Kovid!) so why use another?

[pollito pito]

Hi Kovid,
Sorry but I did not get it.
If as you said the

javascript is only loaded once the full page has finished loading rather than at the start

there would be no way my script could trap the $(document).ready . However it does. You can test it adding
$(document).ready(function(){ alert('1'); });
to the imajes.js . It is as if the page was constructed twice: first with javascript loaded ahead and then with it loaded
afterwards. Is the only explanation I can find to why the two columns view is displayed just to be removed.

In any case, until I find some time for a better solution, just changed the script from
$(document).ready(
to
$(document).dblclick( .

Thanks.

[kovidgoyal]

My guess is that $(document.ready) is never being called, because the javascript is no loaded after that event fires. Try just putting your code at the top level

[pollito pito]

Originally Posted by kovidgoyal

My guess is that $(document.ready) is never being called, because the javascript is no loaded after that event fires. Try just putting your code at the top level

But it is being called. The sequence seems to be like this:
1-document flow is loaded
2-a javascript aware document is rendered. One can test it using $(document).ready(function(){ alert('ready fired'); });
3-javascript is unloaded
4-document is rendered again
5-javascript is loaded

But all this is only important if it was some bug, otherwise please ignore it.
I’m simply sorry that can not contribute more…

[kovidgoyal]

I put the alert into images.js and it is run only once for for me per load of an html file

[pollito pito]

Originally Posted by kovidgoyal

I put the alert into images.js and it is run only once for for me per load of an html file

Yes, indeed. The problem is that it should not run at all!

You explained that the script engine is not loaded anymore
at the beginning, but rather after the full page is loaded.
If I understand correctly, this necessarily means that the
ready event can not be handled via jQuery, because the DOM
is ready before the HTML parser is JavaScript aware.

What I see is that the when I invoke the reader, it shows an
spinner and a message saying “loading document flow”. After
it finishes, my script is fired and the document
rearranged in two columns, but somehow grayed out.
Later on, after a second or so, the two columns layout disappears.

I suggested the theory that maybe the document is rendered
twice and that the script engine is loaded, unloaded and loaded
again. But, I may be off by miles

[kovidgoyal]

Apparently jquery still simulates the ready event.

[pollito pito]

Originally Posted by kovidgoyal

Apparently jquery still simulates the ready event.

Yes, but how? I mean, jquery can do nothing until the JavaScript library is loaded ...

[kovidgoyal]

yes by simulates I mean that it fires the event once it is loaded if the document is already ready

[pollito pito]

Wait, it seems I did not get you and I am now really confused.
In your first message when you said that “the sequence of
javascript library loading has changed”, were you referring to the
JavaScript engine?
I mean, were you talking of the interpreter or however is called
in WebKit, the thing that executes the JavaScript?

Or maybe you were talking about the jQuery library?

In any case, this whole issue seems to be an old bug in jQuery or WebKit
(see here), but it somehow was not affecting calibre before.

[kovidgoyal]

no i mean the loading of all the javascript libraries, including jQuery. Earlier they were being loaded when the window object is cleared, now they are loaded after the document object is ready.