Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Formats > Kindle Formats

Notices

Reply
 
Thread Tools Search this Thread
Old 10-20-2014, 02:56 AM   #1081
eureka
but forgot what it's like
eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.
 
Posts: 728
Karma: 2314258
Join Date: Dec 2011
Location: north (by northwest)
Device: Kindle Touch
Quote:
Originally Posted by KevinH View Post
Yes that would be a good idea but I had not figured out how to push the historic release tags from my local tree to github yet, so there were no releases to link to when I made the post. I only found out how to do that today.
So I just was telling you what you already knew and was planning to use. Sorry for noise. Nice work with tagging!
eureka is offline   Reply With Quote
Old 10-20-2014, 03:17 AM   #1082
quiris
Connoisseur
quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.quiris is no ebook tyro.
 
quiris's Avatar
 
Posts: 96
Karma: 1432
Join Date: Oct 2013
Location: Poland
Device: Kindle Paperwhite
Quote:
Originally Posted by quiris View Post
Is there an open github.com repository with KindleUnpack source code? It would be easier to track changes…
Quote:
Originally Posted by KevinH View Post
The url for the repository is:
https://github.com/kevinhendricks/KindleUnpack
At last… Thank you
quiris is offline   Reply With Quote
Old 10-20-2014, 04:43 AM   #1083
eureka
but forgot what it's like
eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.eureka ought to be getting tired of karma fortunes by now.
 
Posts: 728
Karma: 2314258
Join Date: Dec 2011
Location: north (by northwest)
Device: Kindle Touch
Quote:
Originally Posted by eschwartz View Post
Yep, basically you get a pretty icon and a clicky to your GitHub profile in the commit log plus credit here: https://github.com/kevinhendricks/Ki...kevinhendricks
And credit in contributors list.
eureka is offline   Reply With Quote
Old 10-20-2014, 02:58 PM   #1084
Peter Ahlstrom
Member
Peter Ahlstrom began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Oct 2011
Device: iPad
Quote:
Originally Posted by KevinH View Post
Thank you so much for submitting your bug report and test case as it helps us to better understand the inner workings of the mobi format!
Great! Glad I was able to help.
Peter Ahlstrom is offline   Reply With Quote
Old Today, 08:36 AM   #1085
tkeo
Connoisseur
tkeo began at the beginning.
 
Posts: 87
Karma: 10
Join Date: Feb 2014
Location: Japan
Device: Kindle PaperWhite, Kobo Aura HD
Hi Kevin,

I have fixed a bug in the python2and3 branch on the github.
In addition, I have modified to make eaier to compare the unpacked results by python 2 and python 3.

Take care,
Attached Files
File Type: zip python2and3.patch.zip (1.8 KB, 2 views)
tkeo is offline   Reply With Quote
Old Today, 10:35 AM   #1086
KevinH
Guru
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 954
Karma: 410248
Join Date: Nov 2009
Device: many
Hi tkeo,
Do we really need to overwrite all dictionaries with ordered dictionaries?

I would prefer we explicitly use ordered dicts only where needed (and none are actually truly needed here ... ). If you have some justification as to why you need an ordered dict then import it as something other than dict and use it only where needed explicitly.

Also, the flake8 style checks require a space after the "#" for comments. Better yet simply delete those extra HtmlParser related lines since the compatibility_utils unescapeit removes their use completely.

If you can fix both of these and have a github account, please create a fork and pull request, so that you get the proper credit in the history.

Thanks,

Kevin

Last edited by KevinH; Today at 03:11 PM. Reason: updated now that I understand that dict() is a builtin for a normal dictionary
KevinH is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Can i rotate text and insert images in Mobi and EPUB? JanGLi Kindle Formats 5 02-02-2013 04:16 PM
PDF to Mobi with text and images pocketsprocket Kindle Formats 7 05-21-2012 07:06 AM
Mobi files - images DWC Introduce Yourself 5 07-06-2011 01:43 AM
pdf to mobi... creating images rather than text Dumhed Calibre 5 11-06-2010 12:08 PM
Transfer of images on text files anirudh215 PDF 2 06-22-2009 09:28 AM


All times are GMT -4. The time now is 05:19 PM.


MobileRead.com is a privately owned, operated and funded community.